Allow Nginx to use UNIX sockets as upstream #4857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj84
force-pushed
the
nginx-unix-sockets
branch
from
a15eed5 to
55686a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nginx is usually capable of using UNIX sockets as an upstream server which yields quite a performance increase compared to TCP.
However with this plugin, it is currently not possible, because the port field requires a numeric value.
Since this is the only thing missing for a working UNIX socket support, I have changed the port field to be a text field.
After this change, we can specify a UNIX socket upstream like this:
Fixes #2767