Implementation/64524 recalculate when a score of a scored list is changed within the administration #20511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EinLama
force-pushed
the
implementation/64524-recalculate-when-a-score-of-a-scored-list-is-changed-within-the-administration
branch
from
a69cd9f to
eeb3263
Compare
Rendering "#{id} not found" does not make a lot of sense.
toy
changed the base branch from
dev
to
implementation/64523-allow-usage-of-custom-fields-of-type-hierarchy-with-a-value-within-a-calculated-values-formula
toy
reviewed
Oct 2, 2025
|
|
||
| return unless custom_field.field_format_scored_list? | ||
|
|
||
| custom_field.projects.each do |project| |
There was a problem hiding this comment.
This explicitly binds to projects maybe better to do it like in CustomFields::UpdateService.
Or maybe even go through custom values of this field that have value set to the deleted/updated item id
| item = cached_typed_value | ||
|
|
||
| item.score.presence || item | ||
| item&.score.presence || item |
|
|
||
| if item.nil? | ||
| "#{value} #{I18n.t(:label_not_found)}" | ||
| "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/64524
Important
This branch is based on #20454. Either merge that one first - or merge this branch into it instead of
dev.What are you trying to accomplish?
When the score of a scored list is changed within the administration, all Calculated Values that are using the scored list should be recalculated.
Notes
In case I have to take my parental leave in the near future, here are some notes on the current state of this PR:
hierarchy_strategy.rb). But I did not yet double check if that broke the UI somewhere else. Please be aware that the strategy is not only used by Scored Lists, but also by Hierarchies. If Hierarchies need the error string, we could simply include a type check and render a different formatted value.hierarchical_item_service_spec.rb) - but I am not happy with them. They utilize the database quite a lot. I feel like it should be possible without doing so - but then, I had to mock too much for my taste. Maybe you have a better idea of how to do this.scored_lists_and_calculated_values_spec.rbTL;DR: Everything should work. Specs ugly. Please double-check if there are other cases in which recalculation might be needed for Scored Lists. Thank you!
Screenshots
scored.lists.update.when.score.changes.mov
Merge checklist