Bug/58342 creating a project via template sends out mail notifications to all template users

[toy]

Ticket

https://community.openproject.org/wp/58342

What are you trying to accomplish?

Prevent notifications from being sent sometimes when project is copied with «Send email notifications during the project copy» is unchecked. Why was the bug happening:

• ActionMailer::Base.perform_deliveries was set around call to Projects::CopyService (using with_deliveries)
• in most cases send_notifications is used only by BaseContracted to set Journal::NotificationConfiguration.active?, for the duration of perform and attempts to provide send_notifications to wrapped service calls are ignored and logged
• this is not the case for Members::CreateService, as send_notifications, if set, is also used to override Journal::NotificationConfiguration.active? (Members::Concerns::NotificationSender#send_notifications?)
• Members::CreateService is called for every member from Projects::Copy::MembersDependentService and was receiving send_notifications explicitly set to ActionMailer::Base.perform_deliveries
• this was expected to not be a problem, as ActionMailer::Base.perform_deliveries was set around call to Projects::CopyService to the desired value
• but perform_deliveries is a class attribute, so not thread local and it was set to true before every request and job run (by Setting::MailSettings#reload_mailer_settings!), which was done to ensure email sending configuration is up to date if changed from admin
• so if any job was started after perform_deliveries was set around Projects::CopyService and before Projects::Copy::MembersDependentService finished, perform_deliveries was reset to true and Members::CreateService was called with send_notifications: true forcing it to send notifications (and perform_deliveries = true was allowing them to be sent)
• this also should have caused reverse effect if in the middle of a copy project job with «Send email notifications during the project copy» another one started with the preference unchecked forcing no notifications until any other job start reversed the effect, but it should have being rarer and much less obvious, as notifications were not sent when expected to instead of sent when not expected to

What approach did you choose and why?

Stop dynamically setting perform_deliveries in the app (as it is a class variable, so not thread local and is reset on every request and job run) and remove explicitly setting send_notifications in all Projects::CopyService dependencies.

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[Copilot]

Pull Request Overview

This PR fixes a bug where email notifications were incorrectly sent during project copying even when the "Send email notifications during the project copy" option was unchecked. The issue was caused by thread-safety problems with the ActionMailer::Base.perform_deliveries class attribute being used to control notifications across multiple services.

• Remove dynamic setting of ActionMailer::Base.perform_deliveries to avoid thread-safety issues
• Remove explicit send_notifications parameter passing in project copy services
• Add comprehensive test coverage for the notification behavior

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
app/models/setting/mail_settings.rb	Remove automatic setting of perform_deliveries to true during mailer settings reload
app/mailers/application_mailer.rb	Remove with_deliveries helper method that manipulated perform_deliveries
app/workers/copy_project_job.rb	Remove usage of with_deliveries wrapper and clean up error handling
app/services/projects/copy/members_dependent_service.rb	Remove explicit send_notifications parameter from member creation
app/services/projects/copy/wiki_dependent_service.rb	Remove explicit send_notifications parameter from wiki page copying
app/services/projects/copy/work_packages_dependent_service.rb	Remove explicit send_notifications parameter from work package copying
spec/workers/copy_project_job_spec.rb	Add tests to verify notifications are handled correctly without touching perform_deliveries
spec/models/setting_spec.rb	Update tests to reflect that perform_deliveries is no longer set during settings reload
spec/mailers/user_mailer_spec.rb	Remove tests for the deleted with_deliveries method

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}