✨ (pre-flight check) Improve error message #2006
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
anik120
force-pushed
the
improve-preflight-check-error-message
branch
from
6b10130 to
1513098
Compare
There was a problem hiding this comment.
I think it might broke the downstream tests :-(
Last time I think they were matching the string
@tmshort @jianzhangbjz for you be aware of the change.
But I either liked more the new message 👍
anik120
force-pushed
the
improve-preflight-check-error-message
branch
from
1513098 to
1fc3d52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 69.17% 69.26% +0.08%
==========================================
Files 79 79
Lines 7037 7051 +14
==========================================
+ Hits 4868 4884 +16
+ Misses 1887 1885 -2
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -91,7 +91,7 @@ func shouldSkipPreflight(ctx context.Context, preflight Preflight, ext *ocv1.Clu | |||
| func (h *Helm) runPreAuthorizationChecks(ctx context.Context, ext *ocv1.ClusterExtension, chart *chart.Chart, values chartutil.Values, post postrender.PostRenderer) error { | |||
| tmplRel, err := h.renderClientOnlyRelease(ctx, ext, chart, values, post) | |||
| if err != nil { | |||
| return fmt.Errorf("failed to get release state using client-only dry-run: %w", err) | |||
| return fmt.Errorf("error rendering bundle for pre-authorization checks: %w", err) | |||
There was a problem hiding this comment.
| return fmt.Errorf("error rendering bundle for pre-authorization checks: %w", err) | |
| return fmt.Errorf("error rendering content for pre-authorization checks: %w", err) |
Maybe content for when we have more types like Helm and Bundle regestry/v1
WDYT?
Otherwise, LGTM
There was a problem hiding this comment.
Sure that works too 👍🏽
The line "failed to get release state using client-only dry-run" is too jargon heavy, and meaningless for the end user. This PR replaces the error message with a more user friendly text.
anik120
force-pushed
the
improve-preflight-check-error-message
branch
from
1fc3d52 to
a9f2af6
Compare
|
New changes are detected. LGTM label has been removed. |
Description
The line "failed to get release state using client-only dry-run" is too jargon heavy, and meaningless for the end user.
This PR replaces the error message with a more user friendly text.
Reviewer Checklist