Expose batch_size, stride and optimization params from transformer #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation, optimize params to RunConfig
…ion) as True by default
taliboliver
reviewed
May 22, 2025
There was a problem hiding this comment.
Hi @dmartinez05 Thank you so much for the updates. Would it be possible for you to add the new exposed parameters to main.py? and add them to the CHANGELOG.md too? I think thats the only thing missing, everything else looks great. Thank you so much!
|
Done, let me know if I am missing something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose batch_size, stride and optimization params from transformer in opera-adt/distmetrics#40
Runconfig now supports:
stride_for_norm_param_estimation,batch_size_for_norm_param_estimation,optimize