fix: resolve deprecations for implicitly nullable parameters in PHP 8.4 #231

wesolydexter · 2025-04-08T15:32:15Z

Resolved deprecation warnings related to implicitly nullable parameters in PHP 8.4. Adjusted parameter declarations to explicitly use nullable types where default null values are set.

Changes were applied using the fixer with the nullable_type_declaration_for_default_null_value option.

This ensures compatibility with PHP 8.4 and avoids deprecation messages.

Resolved deprecation warnings related to implicitly nullable parameters in PHP 8.4. Adjusted parameter declarations to explicitly use nullable types where default `null` values are set. Changes were applied using the fixer with the `nullable_type_declaration_for_default_null_value` option. This ensures compatibility with PHP 8.4 and avoids deprecation messages.

wesolydexter · 2025-04-10T07:27:11Z

@jcchavezs would you take a look. It'll take 2 min :)

jcchavezs · 2025-04-10T08:24:29Z

I am not part of this project anymore but changes LGTM. I would say you should add a link to the deprecation and support 8.2, 8.3 and 8.4 on the CI and see what happens and maybe @reta or @shakuzen can approve the CI.

reta · 2025-04-10T12:29:45Z

I am not part of this project anymore but changes LGTM. I would say you should add a link to the deprecation and support 8.2, 8.3 and 8.4 on the CI and see what happens and maybe @reta or @shakuzen can approve the CI.

I would love to, have to admit that PHP is not my thing, @codefromthecrypt do you know who can help us here?

BafS

Thank you! We have the same issue in our codebase

shakuzen · 2025-04-11T01:40:07Z

It looks like the CI needs to be updated in order to run. It's getting Missing download info for actions/cache@v2 which looks to be caused by v2 of that Action being EOL: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

Reason: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions

wesolydexter · 2025-04-11T06:11:21Z

I added the missing PHP versions to the CI and updated the cache version.

Reason: The ::set-output command was deprecated by GitHub. Replacing it improves security and ensures compatibility with the latest GitHub Actions standards. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Implementation: Replaced usages of the ::set-output command with the $GITHUB_OUTPUT. Side effects: None expected. The workflow behavior remains the same.

wesolydexter · 2025-04-11T08:00:31Z

I swapped out ::set-output for $GITHUB_OUTPUT because the old one’s outdated.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands

Reason: The workflow was failing on Ubuntu and macOS because the output of the composer cache directory command had extra newlines, which broke the GitHub Actions output format. Implementation: Added a sanitization step to remove newlines and carriage returns from the command output using `tr -d '\n' | tr -d '\r'`. Side effects: None expected. The change ensures consistent behavior on all runners (Windows, macOS, and Linux).

wesolydexter · 2025-04-11T09:48:07Z

I hope that's the end of the surprises...

Reason: The CI workflow was failing because the step that retrieves the composer cache directory was not providing the correct path. This caused issues in subsequent steps that rely on the cache directory. Implementation: Modified the `Get composer cache directory` step to correctly define the path output. Side effects: None expected.

Reason: During tests, an error is thrown: `strpos(): Argument openzipkin#1 ($haystack) must be of type string, null given`. Implementation: Added a safeguard against null values. Additionally: Removed the `version` field from the Docker Compose file as it is unnecessary (the `version` attribute is obsolete). Side effects: None.

Reason: The abstract test classes had a "Test" suffix, which caused deprecation warnings in PHPUnit because it now tries to treat such classes as actual tests. Implementation: Renamed abstract test classes by appending the "Case" suffix to their names. Updated all references to the renamed classes accordingly. Side effects: No functional changes. Only class names were updated.

Reason: Namespace name doesn't match the PSR-0/PSR-4 project structure. Side effects: None expected.

Reason: PHP 8.0 is no longer a supported version. Implementation: Upgraded testing coverage to the latest supported PHP version (security fixes only). Side effects: None expected.

wesolydexter · 2025-04-11T13:05:26Z

From what I can see, there’s probably an issue with access to Coveralls (maybe the token is invalid - I don’t know, it’s in the secrets). However, I also noticed a few other errors and warnings, so I’m fixing those. It’s possible that this test error was interfering with the coverage check.

wesolydexter · 2025-04-14T06:35:39Z

Can someone give an approval?

shakuzen · 2025-04-14T07:02:57Z

Running the tests was failing:

Run composer test -- --coverage-clover=build/logs/clover.xml
> phpunit tests '--coverage-clover=build/logs/clover.xml'
PHPUnit [9](https://github.com/openzipkin/zipkin-php/actions/runs/14403682799/job/40485287264?pr=231#step:9:10).6.22 by Sebastian Bergmann and contributors.
Error response from daemon: No such container: zipkin_php_mysql_test
sh: 1: docker-compose: not found

Reason: This argument should be redundant, but CI tests fail to start, so it might be related to this issue (`Error response from daemon: No such container: zipkin_php_mysql_test`). Implementation: Added the `version` field to the Docker Compose file. Side effects: None expected.

wesolydexter · 2025-04-14T12:05:32Z

One more approval, please.

Reason: `docker-compose: not found`. Implementation: Replaced deprecated `docker-compose` commands with `docker compose`. Side effects: None.

wesolydexter · 2025-04-15T08:49:30Z

That should help.

shakuzen · 2025-04-15T08:53:46Z

Seems to have helped on ubuntu but macos is still having issues

wesolydexter · 2025-04-15T10:26:21Z

It seems that the php-coveralls configuration is causing the issue here. The error Client error occurred. status: 422 Unprocessable Entity and the message Couldn't find a repository matching this job usually indicate a problem with the COVERALLS_REPO_TOKEN configuration. Could you please double-check that the correct token is set in the repository secrets, and verify that the project is properly linked to Coveralls?
If fixing the token isn’t feasible or Coveralls isn’t critical for this project, we might consider removing this step from the workflow, as the coverage report submission isn’t working as expected anyway.

As for macOS, it can be disabled for tests using Docker Compose (for Windows, it has been disabled for a long time).

Reason: The mysql connection test by Docker compose does not work on macOS (`sh: docker: command not found`). Implementation: Previously, the test was skipped only on Windows. This update broadens the condition to skip the test on all non-Linux systems. Side effects: None.

Reason: We cannot push a simple fix due to an outdated CI configuration that has not been maintained for 2 years. Implementation: Commented out the step responsible for uploading coverage reports to the Codecov service. This change may be temporary or used to troubleshoot coverage reporting issues. Documentation references and environment variable configurations remain intact for future reactivation if needed. Side effects: Risk of neglecting code testing.

wesolydexter · 2025-04-15T10:49:43Z

Since I doubt anyone will manage to configure php-coveralls, I suggest disabling it temporarily.

shakuzen

The changes look reasonable to me, but like @reta, PHP is not in my area of expertise.

wesolydexter · 2025-04-17T09:03:25Z

Shall we merge?

wesolydexter · 2025-04-18T07:07:54Z

@reta?

reta · 2025-04-20T16:07:27Z

tests/Integration/Instrumentation/Mysqli/MysqliTest.php

@@ -20,12 +20,12 @@ final class MysqliTest extends TestCase
    private static function launchMySQL(): array
    {
        shell_exec('docker rm -f zipkin_php_mysql_test');
-        shell_exec(sprintf('cd %s; docker-compose up -d', __DIR__));
+        shell_exec(sprintf('cd %s; docker compose up -d', __DIR__));


So this change cuts docker compose v1 off (docker-compose vs docker compose), probably makes sense, just highlighting that

reta · 2025-04-20T16:09:24Z

@reta?

Doing my best, read https://php.watch/versions/8.0/null-safe-operator over and change does look good, the coverage part needs a solution (could be separate pull request, looking into it)

reta · 2025-04-21T02:19:14Z

@codefromthecrypt could you please help with coverage token, I don't have access to repository settings sadly, thank you

shakuzen · 2025-04-21T02:45:37Z

@reta it looks like I have access to the repo settings. Can I help with updating the coverage token? Or I can try adding permissions for you, although I can't figure out why we would have different permissions.

codefromthecrypt · 2025-04-21T05:55:27Z

"coverage token"? we didn't put anything intentionally to require coverage checks... I know we optionally had it at some point, but that's something that can be removed.

codefromthecrypt · 2025-04-21T05:56:18Z

.github/workflows/ci.yml

-          # https://github.com/php-coveralls/php-coveralls/issues/273#issuecomment-537473525
-          COVERALLS_RUN_LOCALLY: 1
-          COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
+#      - name: Upload coverage report to codecov service


I would just delete this whole section

and also delete the icon from the README as well. then no more problem around this.

reta · 2025-04-21T21:36:52Z

@reta it looks like I have access to the repo settings. Can I help with updating the coverage token? Or I can try adding permissions for you, although I can't figure out why we would have different permissions.

Thanks @shakuzen , let's us get rid of this section altogether , as @codefromthecrypt suggested, thank you. @wesolydexter could you please do that? thank you

Reason: Due to the outdated configuration of the Coveralls tool, we are removing code coverage from the project CI. We decided that code coverage can be addressed in a separate PR in the future. Implementation: Code coverage has been removed from the CI pipeline and README.md. Side effects: The support for code coverage should be restored in the future.

wesolydexter · 2025-04-23T13:31:08Z

Done.
@reta @shakuzen @codefromthecrypt

reta · 2025-04-23T13:56:46Z

Done.

Thanks @wesolydexter !

BafS · 2025-04-23T14:53:54Z

.github/workflows/ci.yml

      - name: Cache composer dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v3


Suggested change

uses: actions/cache@v3

uses: actions/cache@v4

FYI the v4 is available too, hopefully it doesn't break anything

ok, now let it stay as it is

wesolydexter · 2025-04-24T07:35:12Z

Who can merge?

codefromthecrypt · 2025-04-24T08:18:13Z

Epic. Thanks!

wesolydexter · 2025-04-24T08:25:00Z

Maybe let's add a 3.2.1 tag?

codefromthecrypt · 2025-04-25T06:56:31Z

@wesolydexter https://github.com/openzipkin/zipkin-php/releases/tag/3.2.1

Thanks for all the work renovating!

wesolydexter mentioned this pull request Apr 8, 2025

Deprecations after upgrading to PHP 8.4 #230

Closed

BafS approved these changes Apr 10, 2025

View reviewed changes

Update actions/cache from v2 to v3 to fix deprecation issue

3af0050

Reason: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions

dmajka added 5 commits April 11, 2025 12:38

Fix namespace issue in MysqliTest

c309923

Reason: Namespace name doesn't match the PSR-0/PSR-4 project structure. Side effects: None expected.

Update CI to upload coverage report for PHP 8.1

bf7a85e

Reason: PHP 8.0 is no longer a supported version. Implementation: Upgraded testing coverage to the latest supported PHP version (security fixes only). Side effects: None expected.

BafS approved these changes Apr 14, 2025

View reviewed changes

Use docker compose instead of docker-compose.

f845d65

Reason: `docker-compose: not found`. Implementation: Replaced deprecated `docker-compose` commands with `docker compose`. Side effects: None.

dmajka added 2 commits April 15, 2025 12:42

shakuzen reviewed Apr 16, 2025

View reviewed changes

reta reviewed Apr 20, 2025

View reviewed changes

codefromthecrypt reviewed Apr 21, 2025

View reviewed changes

reta approved these changes Apr 23, 2025

View reviewed changes

BafS reviewed Apr 23, 2025

View reviewed changes

codefromthecrypt merged commit bad09ac into openzipkin:master Apr 24, 2025
18 checks passed

fix: resolve deprecations for implicitly nullable parameters in PHP 8.4 #231

fix: resolve deprecations for implicitly nullable parameters in PHP 8.4 #231

Uh oh!

Conversation

wesolydexter commented Apr 8, 2025

Uh oh!

wesolydexter commented Apr 10, 2025

Uh oh!

jcchavezs commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reta commented Apr 10, 2025

Uh oh!

BafS left a comment

Choose a reason for hiding this comment

Uh oh!

shakuzen commented Apr 11, 2025

Uh oh!

wesolydexter commented Apr 11, 2025

Uh oh!

wesolydexter commented Apr 11, 2025

Uh oh!

wesolydexter commented Apr 11, 2025

Uh oh!

wesolydexter commented Apr 11, 2025

Uh oh!

wesolydexter commented Apr 14, 2025

Uh oh!

shakuzen commented Apr 14, 2025

Uh oh!

wesolydexter commented Apr 14, 2025

Uh oh!

wesolydexter commented Apr 15, 2025

Uh oh!

shakuzen commented Apr 15, 2025

Uh oh!

wesolydexter commented Apr 15, 2025

Uh oh!

wesolydexter commented Apr 15, 2025

Uh oh!

shakuzen left a comment

Choose a reason for hiding this comment

Uh oh!

wesolydexter commented Apr 17, 2025

Uh oh!

wesolydexter commented Apr 18, 2025

Uh oh!

reta Apr 20, 2025

Choose a reason for hiding this comment

Uh oh!

reta commented Apr 20, 2025

Uh oh!

reta commented Apr 21, 2025

Uh oh!

shakuzen commented Apr 21, 2025

Uh oh!

codefromthecrypt commented Apr 21, 2025

Uh oh!

codefromthecrypt Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

codefromthecrypt Apr 21, 2025

Choose a reason for hiding this comment

Uh oh!

reta commented Apr 21, 2025

Uh oh!

wesolydexter commented Apr 23, 2025

Uh oh!

reta commented Apr 23, 2025

Uh oh!

BafS Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

wesolydexter Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

wesolydexter commented Apr 24, 2025

Uh oh!

Uh oh!

codefromthecrypt commented Apr 24, 2025

jcchavezs commented Apr 10, 2025 •

edited

Loading