Skip to content

Conversation

@benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Nov 3, 2025

Changes

@benoit74 benoit74 self-assigned this Nov 3, 2025
@benoit74 benoit74 added this to the 5.3.0 milestone Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.87%. Comparing base (48da0c6) to head (2808b22).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/zimscraperlib/zim/indexing.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #269      +/-   ##
===========================================
- Coverage   100.00%   99.87%   -0.13%     
===========================================
  Files           41       41              
  Lines         2511     2480      -31     
  Branches       339      340       +1     
===========================================
- Hits          2511     2477      -34     
- Misses           0        1       +1     
- Partials         0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74
Copy link
Collaborator Author

@rgaudin if you can have a quick look at the README modification to be sure it is intelligible ...

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 3f359e0 into main Nov 14, 2025
7 of 9 checks passed
@benoit74 benoit74 deleted the python_3.14 branch November 14, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Python 3.14

3 participants