- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 46
UI revamp architecture fix #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ui-revamp
Are you sure you want to change the base?
Conversation
6177a89    to
    afd0f89      
    Compare
  
    | Question: Now the homepage.db is generated alongside  gutenburg.db? Do we want to delete it afterwards. Or simply directly export this db from memory with  Some db details/logics could be simplified/deleted under #290. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general remarks:
- No need to delete homepage.db
- All generated files (homepage DB and JSON files) must be generated in the tmp folder, where scraper expects to have plenty of space available
- it looks like you've implemented something for #276 but you are not mentioning it at all ... I need details to make an informed decision on this point
- we've agreed in #282 and in live discussions that we need to better understand how homepage.db is going to be smaller than gutenberg.db 115Mb file ; please make such a measurement (or even better, a test ZIM like you did previously)
I've also added few inline comments.
afd0f89    to
    f652f30      
    Compare
  
    | Finish change. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment, mostly OK to merge once this is solved
b7ee04d    to
    347e931      
    Compare
  
    | I also add some basic logic about search (only a few lines about fuzzy search) One issue I encountered is the following line: (btw I think we should settle down the architecture ASAP for later development. | 



Fix #291 <- change to limit book title/author to two lines with ellipsis and show full title on hover
Fix #283 <- delete Favorite Feature
#282 <- change as discussed SQLite + Json per book
Fix #279 <- implement basic sorting for testing new data structure, but with no asc/desc toggle -> may be added as a separate feature/issue
Fix #276 <- Stick to the previous logic