Skip to content

Conversation

@Lorrainnn
Copy link
Collaborator

@Lorrainnn Lorrainnn commented Jul 10, 2025

Fix #291 <- change to limit book title/author to two lines with ellipsis and show full title on hover
Fix #283 <- delete Favorite Feature
#282 <- change as discussed SQLite + Json per book
Fix #279 <- implement basic sorting for testing new data structure, but with no asc/desc toggle -> may be added as a separate feature/issue
Fix #276 <- Stick to the previous logic

@Lorrainnn Lorrainnn force-pushed the ui-revamp-architecture branch from 6177a89 to afd0f89 Compare July 10, 2025 01:18
@Lorrainnn
Copy link
Collaborator Author

Under this structure:
For 20 books
gutenburg db is 92KB
homepage db is 16KB

image

@Lorrainnn Lorrainnn requested a review from benoit74 July 10, 2025 01:29
@Lorrainnn
Copy link
Collaborator Author

image

@Lorrainnn
Copy link
Collaborator Author

image

@Lorrainnn
Copy link
Collaborator Author

Question: Now the homepage.db is generated alongside gutenburg.db? Do we want to delete it afterwards. Or simply directly export this db from memory with Global.add_item_for (like how we export json if this is approachable

Some db details/logics could be simplified/deleted under #290.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general remarks:

  • No need to delete homepage.db
  • All generated files (homepage DB and JSON files) must be generated in the tmp folder, where scraper expects to have plenty of space available
  • it looks like you've implemented something for #276 but you are not mentioning it at all ... I need details to make an informed decision on this point
  • we've agreed in #282 and in live discussions that we need to better understand how homepage.db is going to be smaller than gutenberg.db 115Mb file ; please make such a measurement (or even better, a test ZIM like you did previously)

I've also added few inline comments.

@Lorrainnn Lorrainnn force-pushed the ui-revamp-architecture branch from afd0f89 to f652f30 Compare July 11, 2025 06:15
@Lorrainnn
Copy link
Collaborator Author

Finish change.
I ll look into details in #290 later.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, mostly OK to merge once this is solved

@Lorrainnn Lorrainnn force-pushed the ui-revamp-architecture branch from b7ee04d to 347e931 Compare July 12, 2025 06:45
@Lorrainnn
Copy link
Collaborator Author

Lorrainnn commented Jul 12, 2025

I also add some basic logic about search (only a few lines about fuzzy search)

One issue I encountered is the following line:
// eslint-disable-next-line @typescript-eslint/no-explicit-any let db: any = null
I haven’t found a reliable way to import the correct Database type. Once we finalize the architecture, we can revisit whether this needs a proper solution or can be left as-is.

(btw I think we should settle down the architecture ASAP for later development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants