Skip to content

Drop failure case for stablehlo.dynamic_broadcast_in_dim #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Drop failure case for stablehlo.dynamic_broadcast_in_dim #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0b92bb
Drop failure case for `stablehlo.dynamic_broadcast_in_dim`
rsuderman Apr 7, 2025
6bce121
fix test
rsuderman Apr 7, 2025
fafb83d
remove label to fix checks
rsuderman Apr 7, 2025
3cba2c0
Merge branch 'main' into broadcast_dyn
rsuderman Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions stablehlo/conversions/linalg/tests/miscellaneous.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,24 @@ func.func @constant() -> tensor<i32> {

// -----

// CHECK: #[[MAP0:.+]] = affine_map<(d0, d1) -> (d1)>
// CHECK: #[[MAP1:.+]] = affine_map<(d0, d1) -> (d0, d1)>

// CHECK: @dynamic_broadcast
// CHECK-SAME: %[[VAL_0:[a-zA-Z0-9_]*]]
// CHECK: %[[C1:.+]] = arith.constant 1 : index
// CHECK: %[[EXTRACT:.+]] = tensor.extract %arg1[%[[C1]]] : tensor<2xi32>
// CHECK: %[[CAST:.+]] = arith.index_cast %[[EXTRACT]] : i32 to index
// CHECK: %[[EMPTY:.+]] = tensor.empty(%[[CAST]]) : tensor<1x?xf32>
// CHECK: %[[GENERIC:.+]] = linalg.generic {indexing_maps = [#[[MAP0]], #[[MAP1]]], iterator_types = ["parallel", "parallel"]} ins(%[[VAL_0]] : tensor<?xf32>) outs(%[[EMPTY]] : tensor<1x?xf32>)
func.func public @dynamic_broadcast(%arg0: tensor<?xf32>, %arg1 : tensor<2xi32>) -> (tensor<1x?xf32>) {
%c = stablehlo.constant dense<1> : tensor<1xi32>
%4 = stablehlo.dynamic_broadcast_in_dim %arg0, %arg1, dims = [1] : (tensor<?xf32>, tensor<2xi32>) -> tensor<1x?xf32>
return %4 : tensor<1x?xf32>
}

// -----

// CHECK-LABEL: func @elided_constant
// CHECK: %[[CONSTANT:.*]] = arith.constant dense_resource<__elided__> : tensor<1024xf32>
func.func @elided_constant() -> tensor<1024xf32> {
Expand Down
3 changes: 1 addition & 2 deletions stablehlo/conversions/linalg/transforms/StablehloLegalizeToLinalg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,7 @@ struct HloDynamicBroadcastInDimConverter final
// Use static type info.
auto bcastDims = op.getBroadcastDimensions();
for (auto [idx, dim] : llvm::enumerate(operandType.getShape())) {
if (ShapedType::isDynamic(dim)) continue;

// We can assume if the input is dynamic it is not expanding.
bool isExpanding = dim == 1;
dimExprs[idx] = isExpanding ? rewriter.getAffineConstantExpr(0)
: rewriter.getAffineDimExpr(bcastDims[idx]);
Expand Down