-
Notifications
You must be signed in to change notification settings - Fork 531
🔧 🎨 Revise lint rules #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 🎨 Revise lint rules #3900
Conversation
Signed-off-by: ff137 <[email protected]>
These rules make no difference to codebase when lint check is applied, and therefore aren't needed Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
"C" is not a valid ruff rule; it is selecting "C90", which only has 1 rule, C901, which is explicitly being ignored. Therefore, emphasise that this should be fixed later. Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
|
For reviewers: I recommend going through each commit: https://github.com/openwallet-foundation/acapy/pull/3900/commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Material changes in this PR:
The motivation for the stricter docstring enforcement is coming from the fact that the large Kanon contribution (#3850) includes many micro-format changes (adding/removing blank lines) that touches many files. These types of changes should be applied automatically and enforced by lint checkers, so we don't have to worry about things like that.
If merged before the Kanon PR, this will make reviewing the actual diff much easier.
Immaterial changes in this PR: