-
Notifications
You must be signed in to change notification settings - Fork 531
(fix) Properly use VM key when signing [SD-]JWT #3892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
@PatStLouis @jamshale -- please take a look when you can. @gmulhearn -- @jamshale is on vacation today, so won't see this until next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, its been on my radar for some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Removes unnecessary complexity. I'll give @PatStLouis a chance to review as he did the MultikeyManager implementation.
I'm going to wait to merge this. We're really trying to get the Kanon profile stuff in and I don't want to cause any potential merge conflicts withit. |
@jamshale sounds good! let me know when it's ready and i'll rebase this branch |
…#3892 Signed-off-by: George Mulhearn <[email protected]>
@gmulhearn Can you please update this with main now and we will get it merged? Thx. |
@gmulhearn Sorry. I merged another PR and github isn't letting me update the branch. Could you do it one more time please? |
|
Closes #3891
Utilizes the existing MultikeyManager logic to reduce code (like is done in the w3c ldp module)