Skip to content

Conversation

gmulhearn
Copy link
Contributor

Closes #3891

Utilizes the existing MultikeyManager logic to reduce code (like is done in the w3c ldp module)

Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
@swcurran
Copy link
Contributor

swcurran commented Oct 3, 2025

@PatStLouis @jamshale -- please take a look when you can. @gmulhearn -- @jamshale is on vacation today, so won't see this until next week.

@jamshale jamshale requested a review from PatStLouis October 6, 2025 15:07
Copy link
Contributor

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, its been on my radar for some time.

Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Removes unnecessary complexity. I'll give @PatStLouis a chance to review as he did the MultikeyManager implementation.

@jamshale
Copy link
Contributor

jamshale commented Oct 7, 2025

I'm going to wait to merge this. We're really trying to get the Kanon profile stuff in and I don't want to cause any potential merge conflicts withit.

@gmulhearn
Copy link
Contributor Author

@jamshale sounds good! let me know when it's ready and i'll rebase this branch

gmulhearn-anonyome added a commit to anonyome/aries-cloudagent-python that referenced this pull request Oct 8, 2025
@jamshale
Copy link
Contributor

jamshale commented Oct 8, 2025

@gmulhearn Can you please update this with main now and we will get it merged? Thx.

@jamshale
Copy link
Contributor

jamshale commented Oct 9, 2025

@gmulhearn Sorry. I merged another PR and github isn't letting me update the branch. Could you do it one more time please?

Copy link

@jamshale jamshale merged commit 11928e9 into openwallet-foundation:main Oct 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Wrong [SD-]JWT signer used when using non-default DID VerificationMethod

5 participants