🔊 Improve logging for BaseRecord and Storage operations #3689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff137
force-pushed
the
improve-base-record-logging
branch
from
ebbc082 to
9463717
Compare
This was referenced Apr 30, 2025
ff137
force-pushed
the
improve-base-record-logging
branch
from
2cc735d to
b77505f
Compare
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
ff137
force-pushed
the
improve-base-record-logging
branch
from
b77505f to
f8dd079
Compare
Signed-off-by: ff137 <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to trying to resolve webhooks being emitted before being written to the DB:
These logging changes are done as a separate improvement, and a precursor to refactoring the event bus (#3690)
I'm taking the approach that all CRUD actions should be logged, at least at debug level. And if something raises an exception, there should be a log right before it. Some of the exceptions should just log info (duplicate record, or not found), and others should log warnings. Error logs are reserved for when something goes wrong. So that's what I tried to adhere to.
🚧
I'll run a test suite with these changes, and see if the logging is reasonable or not.