zip2john should sanitize best file name before printing it #5852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For zip2john, if there is only one candiate file, it is being prepeanded to the hash. This file name should also be sanitized and stripped off ':'
ganzm
force-pushed
the
zip2john_filename_sanitization
branch
from
670000d to
12d6b2a
Compare
| ctx->num_candidates, ctx->archive.check_bytes); | ||
| if(ctx->num_candidates == 1) { | ||
| /* sanitize here, as we don't need the raw file_name any more when exiting this function */ | ||
| replace(ctx->best_files[0].file_name, ':', ' '); |
There was a problem hiding this comment.
Just a comment (I haven't tested this): I see we already replace with a space in line 957 in current code but IMHO we should replace with some non-space character such as '_' in both places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For zip2john, if there is only one candiate file, it is being prepeanded to the hash. This file name should also be sanitized and stripped off ':'