[GPU] choose kernel compile option for work_group_(OPS) #30162
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ddykim
approved these changes
Apr 17, 2025
p-durandin
reviewed
Apr 17, 2025
| kernel_string->options += " -cl-std=CL3.0"; | ||
| #elif CL_TARGET_OPENCL_VERSION >= 200 | ||
| kernel_string->options += " -cl-std=CL2.0"; | ||
| #endif |
There was a problem hiding this comment.
Should we keep checking CL Version > 200 ? It looks lost now
sshlyapn
reviewed
Apr 17, 2025
| @@ -72,6 +72,7 @@ struct device_info { | |||
| bool supports_queue_families; ///< Does engine support cl_intel_command_queue_families extension. | |||
| bool supports_image; ///< Does engine support images (CL_DEVICE_IMAGE_SUPPORT cap). | |||
| bool supports_intel_planar_yuv; ///< Does engine support cl_intel_planar_yuv extension. | |||
| bool supports_work_group; ///< Does engine support CL_DEVICE_OPENCL_C_FEATURES(__opencl_c_work_group_collective_functions). | |||
There was a problem hiding this comment.
I think this name might be confusing, how about using the full name supports_work_group_collective_functions?
Comment on lines
+180
to
+183
| if (engine_info.supports_work_group) | ||
| kernel_string->options += " -cl-std=CL3.0"; | ||
| else | ||
| kernel_string->options += " -cl-std=CL2.0"; |
There was a problem hiding this comment.
Why should the support/implementation of some feature affect the kernel's OpenCL version?
| @@ -388,6 +388,7 @@ struct EngineInfo { | |||
| bool enable_sub_groups_emulation = false; | |||
| bool bOptHintsSupport = false; | |||
| bool supports_microkernels = false; | |||
| bool supports_work_group = false; | |||
There was a problem hiding this comment.
[random spot]
We have KernelBase::get_required_device_features_key() function, I suppose this work_group functions should be exposed as an independent option and considering during kernel selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets: