Skip to content

[BuildTime] Remove needless ops.hpp includes #30161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into from
Open

[BuildTime] Remove needless ops.hpp includes #30161

wants to merge 12 commits into from
+3,358 −927

Conversation

t-jankowski
Copy link
Contributor

@t-jankowski t-jankowski commented Apr 15, 2025 •
edited
Loading

Details:

  • Replaced includes of opset definition with its declaration.
  • Adds necessary operator header includes.

Tickets:

@t-jankowski t-jankowski requested review from a team as code owners April 15, 2025 13:36
@t-jankowski t-jankowski requested review from kblaszczak-intel and itikhono and removed request for a team April 15, 2025 13:36
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations category: LP transformations OpenVINO Low Precision transformations category: AUTO OpenVINO AUTO device selection plugin category: docs_snippets OpenVINO docs snippets (docs/snippets) labels Apr 15, 2025
@t-jankowski t-jankowski force-pushed the tj/build-time-opt/include-opsets_ph3 branch 3 times, most recently from cd1c492 to ac5e92a Compare April 16, 2025 15:42
@t-jankowski
Remove needless ops.hpp includes from cpu plugin
11ed555 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski
Remove needless ops.hpp includes from lp transformations
3ae425e 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski
Remove needless ops.hpp includes from src/core - leftovers, global im…
e0d04a0 
…pact

Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski
Remove needless ops.hpp includes from src/tests/ov_helpers
80a9567 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski
Remove needless ops.hpp includes from src/tests and deps
e77ff82 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski
Remove needless ops.hpp includes from cpu plugin
fb55742 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski
Remove needless ops.hpp includes from gpu plugin
9eff919 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski t-jankowski force-pushed the tj/build-time-opt/include-opsets_ph3 branch from 3098f25 to 9eff919 Compare April 16, 2025 19:29
jane-intel
jane-intel approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@jane-intel jane-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve based on the nature of the PR
please merge it on Friday evening to avoid many merge conflicts for developers

@t-jankowski t-jankowski changed the title [PoC] Remove needless ops.hpp includes [BuildTime] Remove needless ops.hpp includes Apr 17, 2025
@mlukasze mlukasze added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 17, 2025
@t-jankowski t-jankowski enabled auto-merge April 17, 2025 11:25
@t-jankowski
Add missing includes
0f0aa70 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski t-jankowski added this pull request to the merge queue Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itikhono itikhono itikhono approved these changes

@olpipi olpipi olpipi approved these changes

@jane-intel jane-intel jane-intel approved these changes

@kblaszczak-intel kblaszczak-intel Awaiting requested review from kblaszczak-intel kblaszczak-intel is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees
No one assigned
Labels
category: AUTO OpenVINO AUTO device selection plugin category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: docs_snippets OpenVINO docs snippets (docs/snippets) category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: LP transformations OpenVINO Low Precision transformations category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-jankowski @itikhono @olpipi @jane-intel