Skip to content

[core] Deprecate ov::Model constructor from ov::NodeVector #30158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2025
Merged

[core] Deprecate ov::Model constructor from ov::NodeVector #30158

merged 5 commits into from
Apr 16, 2025

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Apr 15, 2025 •
edited
Loading

Details:

  • Deprecate ov::Model ctor using ov::NodeVector` as model outputs
  • Use only ov::ResultVector or ov::OutputVector as model outputs

Tickets:

@praasz praasz requested a review from a team as a code owner April 15, 2025 11:12
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Apr 15, 2025
@praasz praasz added the WIP work in progress label Apr 15, 2025
@praasz praasz changed the title Deprecate ov::Model constructor from ov::NodeVector [core] Deprecate ov::Model constructor from ov::NodeVector Apr 15, 2025
@praasz praasz requested review from a team as code owners April 15, 2025 11:33
@praasz praasz requested review from itikhono and removed request for a team April 15, 2025 11:33
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin category: CPU OpenVINO CPU plugin category: Python API OpenVINO Python bindings labels Apr 15, 2025
@github-actions github-actions bot added category: transformations OpenVINO Runtime library - Transformations category: IR FE OpenVINO IR v10 / v11 FrontEnd category: TEMPLATE OpenVINO Template plugin category: AUTO OpenVINO AUTO device selection plugin category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Apr 15, 2025
t-jankowski
t-jankowski approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@t-jankowski t-jankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for core part

@praasz praasz requested a review from akuporos April 16, 2025 05:50
@praasz praasz removed the WIP work in progress label Apr 16, 2025
@praasz praasz added this pull request to the merge queue Apr 16, 2025
Merged via the queue into openvinotoolkit:master with commit 0a177ff Apr 16, 2025
195 checks passed
@praasz praasz deleted the feature/ov-model-ctor-api branch April 16, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@akuporos akuporos akuporos approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

Assignees
No one assigned
Labels
category: AUTO OpenVINO AUTO device selection plugin category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: Python API OpenVINO Python bindings category: TEMPLATE OpenVINO Template plugin category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@praasz @ilya-lavrenov @akuporos @t-jankowski