Skip to content

[GHA] Catch errors install_build_dependencies.sh #30139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 17, 2025
Merged

[GHA] Catch errors install_build_dependencies.sh #30139

merged 28 commits into from
Apr 17, 2025
+26 −17

Conversation

mryzhov
Copy link
Contributor

@mryzhov mryzhov commented Apr 15, 2025

Details:

  • Catch errors install_build_dependencies.sh
  • Fix false positive errors in install_build_dependencies.sh

Tickets:

@mryzhov mryzhov requested review from a team as code owners April 15, 2025 07:35
@ilya-lavrenov ilya-lavrenov added this to the 2025.2 milestone Apr 15, 2025
mryzhov added 17 commits April 15, 2025 12:26
@mryzhov
fixed if condition
14d4a81
@mryzhov
Merge branch 'master' into ci/install_build_dependencies
c9c0ebb
@mryzhov
debug manylinux
2741b1e
@mryzhov
Merge branch 'ci/install_build_dependencies' of https://github.com/mr…
2f0af80 
…yzhov/openvino into ci/install_build_dependencies
@mryzhov
properly detect fedora
2a92bd0
@mryzhov
Revert "properly detect fedora"
66cd563 
This reverts commit 2a92bd0.
@mryzhov
fixed script
5ae8b5b
@mryzhov
Merge branch 'master' into ci/install_build_dependencies
278fef5
@mryzhov
debug print /etc/redhat-release
c2f3cc9
@mryzhov
revert debug print
930157e
@mryzhov
Merge branch 'ci/install_build_dependencies' of https://github.com/mr…
82f61f1 
…yzhov/openvino into ci/install_build_dependencies
@mryzhov
disable centos-sclo-sclo
e729e97
@mryzhov
list all repos
e42f74c
@mryzhov
fixed repo name
06ceacc
@mryzhov
skip_if_unavailable
c14cf4f
@mryzhov
changed repo id
cef1f00
@mryzhov
disabled centos-sclo-sclo
e626f7c
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Apr 16, 2025
akladiev
akladiev reviewed Apr 16, 2025
View reviewed changes
install_build_dependencies.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to pass "set -e" in the bash script itself instead of each script call in Dockerfiles? If not, why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is more risky, the script could generate another false-positive errors and user will see them as warnings

@ilya-lavrenov ilya-lavrenov removed this pull request from the merge queue due to a manual request Apr 16, 2025
@mryzhov mryzhov added this pull request to the merge queue Apr 17, 2025
Merged via the queue into openvinotoolkit:master with commit f1258b1 Apr 17, 2025
189 checks passed
@mryzhov mryzhov deleted the ci/install_build_dependencies branch April 17, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akladiev akladiev akladiev left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@akashchi akashchi akashchi approved these changes

Assignees

@akladiev akladiev

@akashchi akashchi

Labels
category: CI OpenVINO public CI category: docker_env category: dockerfiles
Projects
None yet
Milestone
2025.2
Development

Successfully merging this pull request may close these issues.
4 participants
@mryzhov @ilya-lavrenov @akladiev @akashchi