[NPU] Add error handling for missing configuration file in parseConfigFile #30134
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If a non-existent config file path is given, an error would be thrown: |
|
Hello @darrenbroche @Maxim-Doronin, the change for ticket E-164501 is ready. Could you help to check? Now the compile-tool triggers an error if config file fails to be opened. |
I don't know how to build the tool to verify manually, but the code change and screenshot on this thread look good to me. Thanks! |
|
Hi @darrenbroche ! FYI: you can refer to how-to-build article |
Maxim-Doronin
approved these changes
Apr 15, 2025
|
build_jenkins |
ArtemySkrebkov
approved these changes
Apr 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Currently,
compile_toolignores missing config files if it's passed in using-cparameter.This fix will check if the config file given by the user can be opened and exists, and will throw an exception if it doesn't.
Tickets: