CL/HIER: check number of TLs per SBGP #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjust
approved these changes
Feb 6, 2024
bureddy
reviewed
Feb 6, 2024
bureddy
approved these changes
Feb 6, 2024
Sergei-Lebedev
force-pushed
the
topic/cl_hier_max_tls_sbgp
branch
from
900626e to
59bd777
Compare
samnordmann
approved these changes
Feb 6, 2024
Sergei-Lebedev
force-pushed
the
topic/cl_hier_max_tls_sbgp
branch
2 times, most recently
from
061d289 to
7e5c31c
Compare
|
bot:retest |
Sergei-Lebedev
force-pushed
the
topic/cl_hier_max_tls_sbgp
branch
from
7e5c31c to
fa2c434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add check to CL/HIER to prevent SBGP TL list overflow.
Why ?
For some systems CL/HIER might try to use more than 4 TLs per SBGP. 4 is compile time constant. Fixes bug https://redmine.mellanox.com/issues/3767158
How ?
Ignore TLs if the list already full. Filter out TLs if we know in advance that SBGP size is not supported.