Skip to content

Conversation

@samnordmann
Copy link
Collaborator

What

Check for CX7 nic device in wait on data gtests

https://redmine.mellanox.com/issues/4408247

@artemry-nv
Copy link
Collaborator

bot:retest

2 similar comments
@artemry-nv
Copy link
Collaborator

bot:retest

@artemry-nv
Copy link
Collaborator

bot:retest

@janjust
Copy link
Collaborator

janjust commented Jun 5, 2025

@Sergei-Lebedev ping

@janjust janjust force-pushed the fix_gtest_wait_on_data_cx6 branch from c74049b to b88321f Compare June 11, 2025 20:42
@janjust janjust force-pushed the fix_gtest_wait_on_data_cx6 branch from b88321f to 16b6546 Compare July 9, 2025 10:20
@janjust janjust enabled auto-merge (squash) July 9, 2025 10:20
@Sergei-Lebedev
Copy link
Contributor

seems like valid issue in CI

12:29:42  /opt/nvidia/src/ucc/test/gtest/common/gtest.h:7597:5: error: void value not ignored as it ought to be
12:29:42   7596 |   ::testing::internal::AssertHelper(result_type, file, line, message) \
12:29:42        |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12:29:42   7597 |     = ::testing::Message()
12:29:42        |     ^~~~~~~~~~~~~~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/common/gtest.h:7600:3: note: in expansion of macro ‘GTEST_MESSAGE_AT_’
12:29:42   7600 |   GTEST_MESSAGE_AT_(__FILE__, __LINE__, message, result_type)
12:29:42        |   ^~~~~~~~~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/common/gtest.h:7603:10: note: in expansion of macro ‘GTEST_MESSAGE_’
12:29:42   7603 |   return GTEST_MESSAGE_(message, ::testing::TestPartResult::kFatalFailure)
12:29:42        |          ^~~~~~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/common/gtest.h:12435:5: note: in expansion of macro ‘GTEST_FATAL_FAILURE_’
12:29:42  12435 |     on_failure(gtest_ar.failure_message())
12:29:42        |     ^~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/common/gtest.h:12504:3: note: in expansion of macro ‘GTEST_ASSERT_’
12:29:42  12504 |   GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
12:29:42        |   ^~~~~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/common/gtest.h:12523:3: note: in expansion of macro ‘GTEST_PRED_FORMAT2_’
12:29:42  12523 |   GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_)
12:29:42        |   ^~~~~~~~~~~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/common/gtest.h:14380:3: note: in expansion of macro ‘ASSERT_PRED_FORMAT2’
12:29:42  14380 |   ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
12:29:42        |   ^~~~~~~~~~~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5.h:46:9: note: in expansion of macro ‘GTEST_ASSERT_EQ’
12:29:42     46 |         GTEST_ASSERT_EQ(ibv_query_device(ctx, &device_attr), 0);
12:29:42        |         ^~~~~~~~~~~~~~~
12:29:42  /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5.h:48:27: error: base operand of ‘->’ has non-pointer type ‘ibv_device_attr’
12:29:42     48 |                device_attr->vendor_part_id == 4129;
12:29:42        |                           ^~
12:29:42  In file included from /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5_qps.h:6,
12:29:42                   from /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5_qps.cc:6:
12:29:42  /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5.h:47:27: error: base operand of ‘->’ has non-pointer type ‘ibv_device_attr’
12:29:42     47 |         return device_attr->vendor_id == 0x02c9 &&
12:29:42        |                           ^~
12:29:42  /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5.h:48:27: error: base operand of ‘->’ has non-pointer type ‘ibv_device_attr’
12:29:42     48 |                device_attr->vendor_part_id == 4129;
12:29:42        |                           ^~
12:29:42  �[0m�[91m/opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5_wqe.cc: In member function ‘virtual void test_tl_mlx5_transpose_transposeWqe_Test::TestBody()’:
12:29:42  /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5_wqe.cc:45:25: error: ‘device_attr’ was not declared in this scope; did you mean ‘ibv_device_attr’?
12:29:42     45 |                      << device_attr.vendor_id
12:29:42        |                         ^~~~~~~~~~~
12:29:42        |                         ibv_device_attr
12:29:42  �[0m�[91m/opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5_wqe.cc: In member function ‘virtual void test_tl_mlx5_wait_on_data_waitOnDataWqe_Test::TestBody()’:
12:29:42  /opt/nvidia/src/ucc/test/gtest/tl/mlx5/test_tl_mlx5_wqe.cc:275:25: error: ‘device_attr’ was not declared in this scope; did you mean ‘ibv_device_attr’?
12:29:42    275 |                      << device_attr.vendor_id
12:29:42        |                         ^~~~~~~~~~~
12:29:42        |                         ibv_device_attr
12:29:42  �[0m�[91mmake[1]: *** [Makefile:1614: tl/mlx5/gtest-test_tl_mlx5.o] Error 1
12:29:42  make[1]: *** Waiting for unfinished jobs....
12:29:42  �[0m�[91mmake[1]: *** [Makefile:1628: tl/mlx5/gtest-test_tl_mlx5_qps.o] Error 1
12:29:43  �[0m�[91mmake[1]: *** [Makefile:1642: tl/mlx5/gtest-test_tl_mlx5_wqe.o] Error 1
12:33:36  �[0mmake[1]: Leaving directory '/opt/nvidia/src/ucc/build/test/gtest'
12:33:36  �[91mmake: *** [Makefile:635: install-recursive] Error 1
12:33:36  �[0mThe command '/bin/sh -c ${SRC_DIR}/ucc/.ci/scripts/build_ucc.sh' returned a non-zero code: 2

Copy link
Contributor

@Sergei-Lebedev Sergei-Lebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails

@janjust janjust force-pushed the fix_gtest_wait_on_data_cx6 branch from 16b6546 to 5c29027 Compare September 24, 2025 17:26
@samnordmann samnordmann force-pushed the fix_gtest_wait_on_data_cx6 branch 2 times, most recently from 1b460a4 to f7c1655 Compare October 13, 2025 07:49
@samnordmann samnordmann force-pushed the fix_gtest_wait_on_data_cx6 branch from f7c1655 to c8411b9 Compare October 13, 2025 09:40
@nsarka
Copy link
Collaborator

nsarka commented Oct 14, 2025

Looks good to me if the CI issues were resolved

@janjust janjust force-pushed the fix_gtest_wait_on_data_cx6 branch from c8411b9 to f75071d Compare October 14, 2025 16:12
@janjust janjust merged commit 4e4e866 into openucx:master Oct 15, 2025
9 checks passed
samnordmann added a commit to samnordmann/ucc that referenced this pull request Oct 15, 2025
janjust pushed a commit that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants