Select scooter mode when starting trip from scooter in nearby view #1449
+79
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alec-georgoff
commented
Aug 6, 2025
miles-grant-ibigroup
requested changes
Aug 8, 2025
| const overlayTypes = overlays | ||
| ?.filter((overlay) => overlay?.type === 'otp2')?.[0] | ||
| ?.layers?.map((layer) => layer?.type) | ||
| const handleSetLocation = (location: MapLocationActionArg) => { |
There was a problem hiding this comment.
This is one approach, but could we not fix this by adjusting query params? What if we check for map state in the places where query params are set? Might that be a better separation of concerns than setting modes within the map component?
lib/components/map/default-map.tsx
Outdated
| @@ -486,6 +509,7 @@ const mapStateToProps = (state) => { | |||
| bikeRentalStations: state.otp.overlay.bikeRental.stations, | |||
| carRentalStations: state.otp.overlay.carRental.stations, | |||
| config: state.otp.config, | |||
| currentQuery: state.otp.currentQuery, | |||
There was a problem hiding this comment.
Not a huge fan of importing query info into the map component...
alec-georgoff
commented
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds functionality to automatically select the rental vehicle mode in the trip planner when starting a trip from a selected rental vehicle in Nearby View. The logic respects the existing trip modes that are selected.
Currently blocked until opentripplanner/otp-ui#871 is merged and version bumped.PR Checklist: