Improve toast annoucnements for AT #1422
Open
+7
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
approved these changes
Jun 20, 2025
| @@ -93,17 +93,6 @@ class Wizard extends Component<Props> { | |||
| this._routeTo(nextId) | |||
| } | |||
| } else { | |||
| // Display a toast to acknowledge saved changes | |||
| // (although in reality, changes quietly took effect in previous screens). | |||
| toastPromise( | |||
There was a problem hiding this comment.
Also remove the imports of '../util/toasts' that are now unused.
There was a problem hiding this comment.
Good call, thank you!
| @@ -169,7 +169,9 @@ components: | |||
| A11yPrefs: | |||
| accessibilityRoutingByDefault: Prefer accessible trips by default | |||
| AccountSetupFinishPane: | |||
| message: You are ready to start planning your trips. | |||
| message: >- | |||
| Your changes have been saved. You are ready to start planning trips. Click | |||
There was a problem hiding this comment.
That's a clever change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds "alert" to default settings to more consistently force toast to announce to AT.
Previously "create account complete" announcement upon exiting the wizard was not being announced because the URL/Page title changing was higher priority. Ensuring both announcements were read properly was requiring a complex set of fake
Promises,setTimeoutsand aria settings. That toast is not actually needed, as all the changes were already saved. Instead, replace the toast with the a message on the "Account Complete" screen that informs users changes were saved and that clicking the "finish" button will redirect them.PR Checklist: