Skip to content

Conversation

@pvenum
Copy link

@pvenum pvenum commented May 3, 2024

Contributing checklist

  • Code must follow existing styling conventions
  • Added a descriptive commit message
  • Sample apps updated if needed

Solves issue(s)


## Setup

1. Install the required node modules: `npm install`
Copy link

@chetanvangadiTokbox chetanvangadiTokbox May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the same instructions of Basic Video Chat samples work for tis repo as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this to the opentok-react-native-samples repo?

If this is simply a copy of the BasicVideoChat sample (in opentok-react-native-samples), we could simply have another branch of the opentok-react-native-samples repo (called "test" or "test-develop"), with the modification in the package.json file. (We could protect the branch so it doesn't get deleted.)

Or if we want to add a test app to this repo, maybe it should load the code from the current branch (locally). But I have not figured out how to do that (see this and this).

Or, if we are just going to use this for internal testing, we could create a separate private repo.

Comment on lines +9 to +11
this.apiKey = '47120344';
this.sessionId = '2_MX40NzEyMDM0NH5-MTcxNDc1MzQ4MDc2MH43eVVvZGRKL2R0WVZUVUNFektKaEZOOHh-fn4';
this.token = 'T1==cGFydG5lcl9pZD00NzEyMDM0NCZzaWc9MDE0ODBlZDAwZWEyYzE2OGY1MWZiYzRhYWVlNDM2OWNiYzAxYmZjYzpzZXNzaW9uX2lkPTJfTVg0ME56RXlNRE0wTkg1LU1UY3hORGMxTXpRNE1EYzJNSDQzZVZWdlpHUktMMlIwV1ZaVVZVTkZla3RLYUVaT09IaC1mbjQmY3JlYXRlX3RpbWU9MTcxNDc1MzQ4MSZub25jZT0wLjkyNTcwOTIyMzAzMDk0NCZyb2xlPW1vZGVyYXRvciZleHBpcmVfdGltZT0xNzE3MzQ1NDgxJmluaXRpYWxfbGF5b3V0X2NsYXNzX2xpc3Q9';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to commit these.

@@ -0,0 +1,518 @@
PODS:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should .gitignore this file. It will change.

Copy link
Contributor

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should .gitignore the TestApp/package-lock.json and TestApp/ios/Podfile.lock files. They will change.

@pvenum
Copy link
Author

pvenum commented May 8, 2024

Could we add this to the opentok-react-native-samples repo?

If this is simply a copy of the BasicVideoChat sample (in opentok-react-native-samples), we could simply have another branch of the opentok-react-native-samples repo (called "test" or "test-develop"), with the modification in the package.json file. (We could protect the branch so it doesn't get deleted.)

Or if we want to add a test app to this repo, maybe it should load the code from the current branch (locally). But I have not figured out how to do that (see this and this).

Or, if we are just going to use this for internal testing, we could create a separate private repo.

Yeah we want to point it to local , currently I am using this app to develop some automation tests , pointing this to local is the next to do item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants