Skip to content

Fix OTSubscriberView, OTPublishderView layout issue on iOS #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 0.18.1
Choose a base branch
from
Open

Fix OTSubscriberView, OTPublishderView layout issue on iOS #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b34527
Fix OTSubscriberView, OTPublishderView layout issue on iOS
DmitryTop Jul 23, 2021
833233b
Code style fix
DmitryTop Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions ios/OpenTokReactNative/OTPublisherView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,21 @@ import Foundation

@objc(OTPublisherView)
class OTPublisherView : UIView {
@objc var publisherId: NSString?
@objc var publisherId: NSString? {
didSet {
if let publisherView = OTRN.sharedState.publishers[publisherId! as String]?.view {
publisherView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
addSubview(publisherView)
}
}
}

override init(frame: CGRect) {
super.init(frame: frame)
}

required init?(coder aDecoder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}
override func layoutSubviews() {
if let publisherView = OTRN.sharedState.publishers[publisherId! as String]?.view {
publisherView.frame = self.bounds
addSubview(publisherView)
}
}
}

17 changes: 9 additions & 8 deletions ios/OpenTokReactNative/OTSubscriberView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,21 @@ import Foundation

@objc(OTSubscriberView)
class OTSubscriberView: UIView {
@objc var streamId: NSString?
@objc var streamId: NSString? {
didSet {
if let subscriberView = OTRN.sharedState.subscribers[streamId! as String]?.view {
subscriberView.autoresizingMask = [.flexibleWidth, .flexibleHeight]
addSubview(subscriberView)
}
}
}

override init(frame: CGRect) {
super.init(frame: frame)
}

required init?(coder aDecoder: NSCoder) {
fatalError("init(coder:) has not been implemented")
}

override func layoutSubviews() {
if let subscriberView = OTRN.sharedState.subscribers[streamId! as String]?.view {
subscriberView.frame = self.bounds
addSubview(subscriberView)
}
}
}