-
Notifications
You must be signed in to change notification settings - Fork 170
VIDCS-2050: Screen Sharing Sample App #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new screen sharing sample app that replaces the existing Screen-Sharing samples with two distinct implementations: Webview-Screen-Sharing and Device-Screen-Sharing. The changes rename and reorganize the existing screen sharing samples to better distinguish between webview-based and device-based screen sharing approaches.
- Renamed existing Screen-Sharing samples to Webview-Screen-Sharing to clarify their WebView-based approach
- Added a new Device-Screen-Sharing-Java sample that uses the Android Media Projection API for full device screen capture
- Updated package names, build configurations, and documentation to reflect the new naming convention
Reviewed Changes
Copilot reviewed 40 out of 84 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
Webview-Screen-Sharing-Kotlin/ | Renamed from Screen-Sharing-Kotlin with updated package names and app identifiers |
Webview-Screen-Sharing-Java/ | Renamed from Screen-Sharing-Java with updated package names and app identifiers |
Device-Screen-Sharing-Java/ | New sample app demonstrating device screen sharing using Media Projection API |
README.md | Updated to reflect the new sample organization and naming |
.github/workflows/ | Updated CI workflows to match the new directory names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...creen-Sharing-Java/app/src/main/java/com/tokbox/sample/devicescreensharing/MainActivity.java
Outdated
Show resolved
Hide resolved
...ring-Java/app/src/main/java/com/tokbox/sample/devicescreensharing/ScreenSharingCapturer.java
Show resolved
Hide resolved
…/devicescreensharing/MainActivity.java Co-authored-by: Copilot <[email protected]>
https://jira.vonage.com/browse/VIDCS-2050
Replace #509