Skip to content

Conversation

romanhaa
Copy link

In this PR I suggest changes that extend the configurability at runtime, similar to how it works in the Platform front end (platform-app).

Summary of changes:

  • Update Dockerfile and adopt format used in platform-app.
  • Remove environment variables used at build time (REACT_APP_).
  • The files src/configuration.js and nginx.conf became obsolete and were therefore removed.
  • Use config.helpdeskEmail for both contact elements in src/constants.js.
  • Add DEVOPS_CONTEXT_ variables to public/config.template.

I hope you think this is useful.

- Update `Dockerfile` and adapt format used for `platform-app`.
- Remove environment variables used at build time (`REACT_APP_`).
- The files `src/configuration.js` and `nginx.conf` became obsolete and
  were therefore removed.
- Use `config.helpdeskEmail` for both contact elements in
  `src/constants.js`.
- Add `DEVOPS_CONTEXT_` variables to `public/config.template`.
@andrewhercules
Copy link
Contributor

Thank you @romanhaa for opening this PR! 👍

@carcruz is currently reimplementing the configuration for the genetics-app to match the platform-app. Part of this will be adjusting the configuration to use our profiles-based approach. Once he has opened and merged his PR, I'll ask him to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants