Skip to content

Conversation

@jirimacku
Copy link
Contributor

This patch reverts a recent change in common networking template which gives a precedence to worker nodes causing all other nodes to be skipped.

This patch reverts a recent change in common networking template
which gives a precedence to worker nodes causing all other nodes
to be skipped.
@jirimacku jirimacku requested a review from a team as a code owner October 17, 2025 12:29
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jirimacku jirimacku changed the title Common networking template handle all nodes Common networking template handles all nodes Oct 17, 2025
@evallesp
Copy link
Contributor

My problem with this is this is not going to work in 3+3 scenarios. As NNCP woul dbe configured in ocp-master nodes.
In the other hands this makes specific scenarios as scenarios were NNCP is set in master but also in worker (which is non-schedulable) for testing purpose.

IMO the common scenario should be the first one, and specific one is the second.
In any case, as a note here, we're going to work on adding a logic to take non-schedulable worker nodes, and if so, then we know NNCP shoul dbe configures in master but also in worker nodes: https://issues.redhat.com/browse/OSPRH-20534

More info of why we did this: https://issues.redhat.com/browse/OSPRH-15229

@jirimacku
Copy link
Contributor Author

Replaced by this solution: #3424

@jirimacku jirimacku closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants