Remove deprecated tempest role variables #3418
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
update-edpm.yml
Outdated
| vars: | ||
| pre_tests: "{{ (lookup('vars', 'pre_tempest', default=[])) }}" | ||
| post_tests: "{{ (lookup('vars', 'post_tempest', default=[])) }}" | ||
| pre_tests: [] |
There was a problem hiding this comment.
Is this setting to an empty value to provide a default value because the value will be overridden? I'm always confused by the ansible precedence rules (https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#understanding-variable-precedence).
In other words, do we need to keep the empty definitions here (and in the other file)?
There was a problem hiding this comment.
Suggest to remove the vars and set default value in place where it is used.
There was a problem hiding this comment.
Ack, I changed it to empty list just in case it was used somewhere 🤔
After going through the code I think the variables are not needed, if I understand correctly. It goes to the run_tests.yml playbook which calls the role run_hook and there is no hooks variable being set. There might be dependency even deeper, but to be honest I did not find it, so I just removed the variables.
The pre_tempest and post_tempest variables are now deprecated and the pre_tests and post_tests variables should be used now. This patch removes all the instances of these old variables.
kstrenkova
force-pushed
the
remove-tempest-role-values
branch
from
8582ea6 to
7015564
Compare
4 participants
The pre_tempest and post_tempest variables are now deprecated and the pre_tests and post_tests variables should be used now. This patch removes all the instances of these old variables.