-
Notifications
You must be signed in to change notification settings - Fork 138
Add extra condition for starting update_containers role #3416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra condition for starting update_containers role #3416
Conversation
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7be7f7b0287b4680bf944311c4382cc2 ❌ openstack-k8s-operators-content-provider FAILURE in 13m 05s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f6775597fc3d4cd69e9cc7155c34c3a7 ✔️ openstack-k8s-operators-content-provider SUCCESS in 50m 40s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit would be also to add into that condition:
cifmw_update_containers_edpm_image_url is defined and cifmw_update_containers_edpm_image_url
recheck |
cifmw_update_containers_edpm_image_url is string type of value |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0663dc2997c540a196ecbd3bb431735e ✔️ openstack-k8s-operators-content-provider SUCCESS in 56m 15s |
Ensure update_containers role only runs for cifmw_update_containers_edpm_image_url varaible for osContainerImage when cifmw_update_containers_openstack is also true.
10cffab
930b1d7
to
10cffab
Compare
I simplified parentheses structure in when condition - removed unnecessary double parentheses for better readability while maintaining the same logical grouping in latest revision. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arxcruz, sdatko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ensure update_containers role runs for cifmw_update_containers_edpm_image_url variable set for osContainerImage customization only when cifmw_update_containers_openstack is also true.