Skip to content

Conversation

ciecierski
Copy link
Contributor

@ciecierski ciecierski commented Oct 15, 2025

Ensure update_containers role runs for cifmw_update_containers_edpm_image_url variable set for osContainerImage customization only when cifmw_update_containers_openstack is also true.

@ciecierski ciecierski requested a review from a team as a code owner October 15, 2025 14:19
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7be7f7b0287b4680bf944311c4382cc2

openstack-k8s-operators-content-provider FAILURE in 13m 05s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 5m 11s
⚠️ adoption-standalone-to-crc-ceph-provider SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 10m 02s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 11s
✔️ build-push-container-cifmw-client SUCCESS in 18m 01s
✔️ cifmw-molecule-edpm_prepare SUCCESS in 4m 41s

@amartyasinha
Copy link
Contributor

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f6775597fc3d4cd69e9cc7155c34c3a7

✔️ openstack-k8s-operators-content-provider SUCCESS in 50m 40s
podified-multinode-edpm-deployment-crc FAILURE in 29m 01s
cifmw-crc-podified-edpm-baremetal FAILURE in 36m 32s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 24s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 30m 07s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 40s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 03s
✔️ build-push-container-cifmw-client SUCCESS in 19m 14s
✔️ cifmw-molecule-edpm_prepare SUCCESS in 4m 48s

arxcruz
arxcruz previously approved these changes Oct 16, 2025
Copy link
Contributor

@arxcruz arxcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

sdatko
sdatko previously approved these changes Oct 16, 2025
Copy link
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sdatko sdatko enabled auto-merge (rebase) October 16, 2025 10:00
danpawlik
danpawlik previously approved these changes Oct 16, 2025
Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit would be also to add into that condition:
cifmw_update_containers_edpm_image_url is defined and cifmw_update_containers_edpm_image_url

@danpawlik
Copy link
Contributor

recheck

@ciecierski
Copy link
Contributor Author

nit would be also to add into that condition: cifmw_update_containers_edpm_image_url is defined and cifmw_update_containers_edpm_image_url

cifmw_update_containers_edpm_image_url is string type of value

@ciecierski ciecierski changed the title Add extra openstack condition for starting update_containers role Add extra condition for starting update_containers role Oct 16, 2025
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0663dc2997c540a196ecbd3bb431735e

✔️ openstack-k8s-operators-content-provider SUCCESS in 56m 15s
podified-multinode-edpm-deployment-crc FAILURE in 26m 17s
cifmw-crc-podified-edpm-baremetal FAILURE in 41m 19s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 21s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 30m 21s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 03s
✔️ build-push-container-cifmw-client SUCCESS in 16m 29s
✔️ cifmw-molecule-edpm_prepare SUCCESS in 4m 37s

Ensure update_containers role only runs for cifmw_update_containers_edpm_image_url
varaible for osContainerImage  when cifmw_update_containers_openstack is also true.
@ciecierski ciecierski dismissed stale reviews from danpawlik, sdatko, and arxcruz via 10cffab October 16, 2025 11:52
@ciecierski ciecierski force-pushed the containers_edpm_image_url_customization branch from 930b1d7 to 10cffab Compare October 16, 2025 11:52
@openshift-ci openshift-ci bot removed the lgtm label Oct 16, 2025
@ciecierski
Copy link
Contributor Author

I simplified parentheses structure in when condition - removed unnecessary double parentheses for better readability while maintaining the same logical grouping in latest revision.

@jistr
Copy link
Contributor

jistr commented Oct 16, 2025

/lgtm

Copy link
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sdatko sdatko merged commit 446f052 into openstack-k8s-operators:main Oct 20, 2025
6 checks passed
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arxcruz, sdatko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants