Replace hardcoded /home/zuul paths in kustomize_deploy & ci_gen_kustomize_values

[bshewale]

Replace hardcoded /home/zuul/ paths with ansible_user_dir variable in kustomize_deploy & ci_gen_kustomize_values role to support different user environments and improve consistency with configurable user variables pattern.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f2d1d95ba9754301a84d59cad8fdd4e4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 42s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 43m 00s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 39s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 35s
❌ cifmw-pod-pre-commit FAILURE in 6m 13s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 47s
✔️ build-push-container-cifmw-client SUCCESS in 20m 39s
❌ cifmw-molecule-ci_gen_kustomize_values FAILURE in 3m 25s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 38s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/72ba670fbc3642d1af7041e3d6608b7a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 23s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 49s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 40s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 34s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 24s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 46s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 07s
✔️ build-push-container-cifmw-client SUCCESS in 18m 46s
❌ cifmw-molecule-ci_gen_kustomize_values FAILURE in 5m 49s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 6m 22s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f1683ad050ca40d98be9f3f59ef22d1d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 23s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 41s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 59s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 42s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 49s
✔️ cifmw-architecture-validate-hci SUCCESS in 5m 16s
✔️ build-push-container-cifmw-client SUCCESS in 20m 14s
❌ cifmw-molecule-ci_gen_kustomize_values FAILURE in 3m 48s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 54s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/de18c89c6f8b49be80aac12f58e7f158

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 31s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 40s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 20s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 40s
✔️ cifmw-architecture-validate-hci SUCCESS in 6m 17s
✔️ build-push-container-cifmw-client SUCCESS in 20m 52s
❌ cifmw-molecule-ci_gen_kustomize_values FAILURE in 3m 17s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 20s

[danpawlik]

diff --git a/roles/ci_gen_kustomize_values/molecule/default/prepare.yml b/roles/ci_gen_kustomize_values/molecule/default/prepare.yml
index 34cbe58d..b11327d2 100644
--- a/roles/ci_gen_kustomize_values/molecule/default/prepare.yml
+++ b/roles/ci_gen_kustomize_values/molecule/default/prepare.yml
@@ -20,7 +20,7 @@
   vars:
     cifmw_ci_gen_kustomize_values_src_dir: >-
       {{
-        (lookup('env', 'HOME', '/home/zuul'),
+        (lookup('env', 'HOME'),
          'ci-framework-data',
          'artifacts', 'ci_k8s_snippets') | path_join
       }}
@@ -47,5 +47,6 @@

 - name: Download tools for later testing and validations
   ansible.builtin.import_playbook: >-
-    {{ ('/home/zuul/src/github.com/openstack-k8s-operators',
+    {{ (lookup('env', 'HOME'),
+        'src/github.com/openstack-k8s-operators',
         'install_yamls/devsetup/download_tools.yaml') | path_join }}

that works on my side

[softwarefactory-project-zuul]

This change depends on a change that failed to merge.

Change #3411 is needed.

[bshewale]

recheck

[bshewale]

diff --git a/roles/ci_gen_kustomize_values/molecule/default/prepare.yml b/roles/ci_gen_kustomize_values/molecule/default/prepare.yml
index 34cbe58d..b11327d2 100644
--- a/roles/ci_gen_kustomize_values/molecule/default/prepare.yml
+++ b/roles/ci_gen_kustomize_values/molecule/default/prepare.yml
@@ -20,7 +20,7 @@
   vars:
     cifmw_ci_gen_kustomize_values_src_dir: >-
       {{
-        (lookup('env', 'HOME', '/home/zuul'),
+        (lookup('env', 'HOME'),
          'ci-framework-data',
          'artifacts', 'ci_k8s_snippets') | path_join
       }}
@@ -47,5 +47,6 @@

 - name: Download tools for later testing and validations
   ansible.builtin.import_playbook: >-
-    {{ ('/home/zuul/src/github.com/openstack-k8s-operators',
+    {{ (lookup('env', 'HOME'),
+        'src/github.com/openstack-k8s-operators',
         'install_yamls/devsetup/download_tools.yaml') | path_join }}

that works on my side

Working.