Create a template for nova04delta #3392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bohdan Dobrelia <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
evallesp
reviewed
Oct 9, 2025
| {% set _original_nodes = _original_nodeset.nodes | default({}) %} | ||
| {% set _original_services = _original_nodeset['services'] | default([]) %} | ||
| {% for _inst in cifmw_networking_env_definition.instances.keys() %} | ||
| {% if _inst.startswith('compute') %} |
evallesp
previously approved these changes
Oct 9, 2025
Do not define ansible.host and fixedIP for non pre-provisioned host. Fix bmh template. Signed-off-by: Bohdan Dobrelia <[email protected]>
danpawlik
reviewed
Oct 15, 2025
| # source: nova04delta/edpm-nodeset-values/values.yaml.j2 | ||
| {% set _ipv = cifmw_ci_gen_kustomize_values_ip_version_var_mapping %} | ||
| {% set instances_names = [] %} | ||
| {% set _original_nodeset = (original_content.data | default({})).nodeset | default({}) %} |
There was a problem hiding this comment.
no need to have double default.
{% set _original_nodeset = (original_content.data.nodeset | default({}) %}
danpawlik
reviewed
Oct 15, 2025
roles/ci_gen_kustomize_values/templates/nova04delta/edpm-nodeset-values/values.yaml.j2
Show resolved
Hide resolved
danpawlik
reviewed
Oct 15, 2025
roles/ci_gen_kustomize_values/templates/nova04delta/edpm-nodeset-values/values.yaml.j2
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of #3369 but rebased on main branch, plus an extra fix