-
Notifications
You must be signed in to change notification settings - Fork 138
Add building Tempest timing data url #3356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add building Tempest timing data url #3356
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bd07a3f to
490b7d6
Compare
|
@danpawlik Thank you for the review! It was very helpful, I even noticed one mistake I did in the logic. If you have any doubts please add comments again. It can be even nitpicks, as I am not very well versed in ansible yet I would like to learn from my mistakes :D. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better. Thank you.
I will take a look later in logs how it is working.
490b7d6 to
ce945f6
Compare
ce945f6 to
c835027
Compare
c835027 to
4642758
Compare
4642758 to
ae6544a
Compare
There is a relatively new parameter added to test-operator, called TimingDataUrl. We are trying to make the parameter work with jobs, but the issue is that there is no variable that stores the final Tempest pod name that will be created. Without it, we cannot build the timing data url, as we are saving the data under job/test-name folder. This change adds a way to build the final url for both tests with and without workflow.
ae6544a to
979daab
Compare
|
Tested in testproject 1484 (not sure if I can paste internal links here). I would appreciate your reviews again @sdatko and @danpawlik, now that the code should work as expected in all scenarios:
|
There is a relatively new parameter added to test-operator, called TimingDataUrl. We are trying to make the parameter work with jobs, but the issue is that there is no variable that stores the final Tempest pod name that will be created. Without it, we cannot build the timing data url, as we are saving the data under job/test-name folder.
This change adds a way to build the final url for both tests with and without workflow.