Skip to content

check hold label before merging #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

check hold label before merging #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions review-tools/ghmerge
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ from __future__ import print_function
import json, sys
rtm_set=0
urgent_set=0
has_hold=0
input = json.load(sys.stdin)
# Dont do this check if its not for the openssl repo
if (input["base"]["repo"]["name"] != "openssl"):
Expand All @@ -189,8 +190,14 @@ for l in input["labels"]:
rtm_set=1
if (l["name"] == "severity: urgent"):
urgent_set=1
if (l["name"] == "hold: committer discussion"):
has_hold=1

if (rtm_set == 0 and urgent_set == 0):
print("Not ready to merge")

if (has_hold == 1):
print("Not ready to merge")
' <$PR_URL_CONTENTS)

if [ "$REPO_CHECK" == "Not ready to merge" ]
Expand Down