Skip to content

Conversation

@kenyiu
Copy link
Member

@kenyiu kenyiu commented Sep 26, 2025

FIx this: #2186 (comment)

@vercel
Copy link

vercel bot commented Sep 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
kariba-network Ready Ready Preview Comment Nov 18, 2025 3:57pm
oso-www Ready Ready Preview Comment Nov 18, 2025 3:57pm

Copy link
Member

@ccerv1 ccerv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between a "first time" contributor and a "new" contributor?

I believe we already have "new" contributors working, right?

@kenyiu
Copy link
Member Author

kenyiu commented Sep 27, 2025

For the logic of new contributor now, its relying on the author_association provided by github. There are a few issues for using it:

  1. It will be removed: https://github.blog/changelog/2025-08-08-upcoming-changes-to-github-events-api-payloads/#whats-changing
  2. The logic now is only considering first pr as new contributor, which seems not fitting our updated scenarios

Then, i used the label name proposed in your table without rewriting the new_contributor one, but we can definitely update the one.

@kenyiu kenyiu temporarily deployed to external-prs-app October 4, 2025 01:14 — with GitHub Actions Inactive
@kenyiu
Copy link
Member Author

kenyiu commented Nov 15, 2025

@ccerv1 for now, the metrics contributor_activity_classification is updated and providing the following count monthly/yearly:

first_time_contributor
churned_after_first_time_contributor
new_part_time_contributor
new_full_time_contributor
churned_after_part_time_contributor
active_part_time_contributor
part_time_to_full_time_contributor
churned_after_full_time_contributor
active_full_time_contributor
full_time_to_part_time_contributor
reactivated_part_time_contributor
reactivated_full_time_contributor

is it enough for the scope of work?

Also, in such case, should I update the existing lifecycle metrics to include all the changes in number of the type of contributors? Btw, the word lifecycle is a bit confusing with the new classifications and scope of work. maybe we should rename it as well.

Copy link
Member

@ccerv1 ccerv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kenyiu
Many thanks for this! Excited to see what the results look like.
FYI, I created a small test version last week. It's in this model: int_pln_developer_lifecycle_monthly

I've approved your PR and we can merge it and see what results we get. Ideally we can diff them against some of the projects included in my test version and see if we get similar numbers.

Feel free to merge if you feel it's ready to go. (It ran locally and passed CI as well.)

@kenyiu
Copy link
Member Author

kenyiu commented Nov 18, 2025

@ccerv1 thanks. let's merge it first, and we can check how it goes before modifying the lifecycle sql for the changes in number of different classifications of contributors.

@kenyiu kenyiu added this pull request to the merge queue Nov 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2025
@kenyiu kenyiu added this pull request to the merge queue Nov 18, 2025
Merged via the queue into main with commit 8585e39 Nov 18, 2025
13 checks passed
@kenyiu kenyiu deleted the kenyiu/new-lifecycle branch November 18, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants