Skip to content

OCPBUGS-61398: fix(test): prevent nil pointer dereference in ginkgo test runner #30224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

OCPBUGS-61398: fix(test): prevent nil pointer dereference in ginkgo test runner #30224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/test/ginkgo/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ func (s *testSuiteProgress) TestEnded(testName string, testRunResult *testRunRes
s.lock.Lock()
defer s.lock.Unlock()

if testRunResult == nil {
return
}

if isTestFailed(testRunResult.testState) {
s.failures++
}
Expand Down
8 changes: 8 additions & 0 deletions pkg/test/ginkgo/test_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,10 @@ func recordTestResultInLogWithoutOverlap(testRunResult *testRunResultHandle, tes
}

func recordTestResultInLog(testRunResult *testRunResultHandle, out io.Writer, includeSuccessfulOutput bool) {
if testRunResult == nil {
return
}

// output the status of the test
switch testRunResult.testState {
case TestFlaked:
Expand Down Expand Up @@ -257,6 +261,10 @@ func recordTestResultInLog(testRunResult *testRunResultHandle, out io.Writer, in
}

func recordTestResultInMonitor(testRunResult *testRunResultHandle, monitorRecorder monitorapi.Recorder) {
if testRunResult == nil {
return
}

eventLevel := monitorapi.Warning

msg := monitorapi.NewMessage().HumanMessage("e2e test finished")
Expand Down