Fixing the Failure for make update for OCP-80983 on 4.20 #29883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
@asahay19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 2114960
New tests seen in this PR at sha: 2114960
|
|
Looks like the test is failing now |
|
@dusk125: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm cancel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: asahay19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
make updatefor this PR#29883. Test case OCP-80983 is getting failed in make update with below error:
goroutine 1 [running]: runtime/debug.Stack() /usr/local/go/src/runtime/debug/stack.go:26 +0x5e github.com/openshift/origin/test/extended/util.FatalErr({0x6710e80, 0xc002325560}) /home/asahay/OCP-80983/origin/test/extended/util/client.go:1023 +0x25 github.com/openshift/origin/test/extended/util.(*CLI).AdminConfig(0x0?) /home/asahay/OCP-80983/origin/test/extended/util/client.go:824 +0x3b github.com/openshift/origin/test/extended/util.(*CLI).SetupProject(0xc0023eac80) /home/asahay/OCP-80983/origin/test/extended/util/client.go:314 +0x1c github.com/openshift/origin/test/extended/node.init.func1() /home/asahay/OCP-80983/origin/test/extended/node/cgroups.go:23 +0xe5 github.com/onsi/ginkgo/v2/internal.NewNode.func2({0xc0023ea780?, 0x0?}) /home/asahay/OCP-80983/origin/vendor/github.com/onsi/ginkgo/v2/internal/node.go:324 +0x13 github.com/onsi/ginkgo/v2/internal.(*Suite).PushNode.func1(0xc0014c2908?) /home/asahay/OCP-80983/origin/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:209 +0x5b github.com/onsi/ginkgo/v2/internal.(*Suite).PushNode(_, {0x193, 0x2, {0x700cdee, 0x72}, 0xc000f9b120, {{0x8bf23cb, 0x3b}, 0x10, {0x0, ...}, ...}, ...}) /home/asahay/OCP-80983/origin/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:211 +0x71e github.com/onsi/ginkgo/v2/internal.(*Suite).BuildTree(0xc000893508) /home/asahay/OCP-80983/origin/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:101 +0xb8 k8s.io/kubernetes/openshift-hack/e2e/annotate.Run(0xa61c878?, 0x71be008) /home/asahay/OCP-80983/origin/vendor/k8s.io/kubernetes/openshift-hack/e2e/annotate/annotate.go:31 +0xd5 main.main() /home/asahay/OCP-80983/origin/test/extended/util/annotate/annotate.go:14 +0x25So, fixing it by removing oc.SetupProject() .
cc @sairameshv