WIP: add volume group snapshot tests #29576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The tests need deployment of csi-driver-hostpath with enabled group snapshots. Upstream uses a script, which cannot be used in OCP. We replace the script with a code that copies upstream csi-hostpath test driver as "csi-hostpath-groupsnapshot" that run the driver with group snapshots enabled.
Volume group snapshot tests in test/extended/storage/group_snapshot.go re-configure and generate ginkgo tests defined in k8s.io/kubernetes/test/e2e/storage/testsuites. These tests get `[Suite:k8s]`, because they're in k8s.io/kubernetes, but these tests are newly added in origin, they don't have a counterpart in Kubernetes. Add a override `[OCPForce]` to include them in origin tests and don't expect them to be in k8s-test-ext.
jsafrane
force-pushed
the
4.19-groupsnapshot
branch
from
9808ba6 to
bab0add
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/test help |
|
@jsafrane: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-aws-ovn-single-node-techpreview-serial |
|
/test e2e-gcp-ovn-techpreview-serial |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: bab0add
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a hack