Skip to content

[release-4.19] OCPBUGS-56993:ART requests updates to 4.19 image ose-openshift-apiserver-container #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release-4.19
Choose a base branch
from

Conversation

wangke19
Copy link
Contributor

@wangke19 wangke19 commented Jun 3, 2025

Backport PR #486 to release-4.19 manually.

@openshift-ci openshift-ci bot requested review from abhgupta and adambkaplan June 3, 2025 02:03
@wangke19 wangke19 changed the title [release-4.19] Backport pr 486 to release 4.19 [release-4.19] Backport #486:ART requests updates to 4.19 image ose-openshift-apiserver-container Jun 3, 2025
@wangke19 wangke19 changed the title [release-4.19] Backport #486:ART requests updates to 4.19 image ose-openshift-apiserver-container [release-4.19] OCPBUGS-56993:ART requests updates to 4.19 image ose-openshift-apiserver-container Jun 3, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-56993, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport PR #486 to release-4.19 manually.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Jun 3, 2025

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-56993, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Jun 3, 2025

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-56993, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Jun 3, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-56993, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-45729 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-45729 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gangwgr June 3, 2025 02:42
@vrutkovs
Copy link
Member

vrutkovs commented Jun 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2025
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs, wangke19
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangke19
Copy link
Contributor Author

wangke19 commented Jun 3, 2025

/test e2e-aws-ovn-serial

Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wangke19
Copy link
Contributor Author

wangke19 commented Jun 4, 2025

/assign @p0lyn0mial

@p0lyn0mial
Copy link
Contributor

oh, wow, ~3400 files changed, the diff is huge.

why do we want to back port ?
does it fix any significant bug/issue ?

@wangke19
Copy link
Contributor Author

wangke19 commented Jun 4, 2025

why do we want to back port ?

The main branch PR #486 started working on branch 4.19 at the very beginning. Because some dependencies(openshift/kubernetes-apiserver#65) were not resolved, it was finally completed in the new main branch(4.20). Another reason is bug https://issues.redhat.com/browse/OCPBUGS-56893.

does it fix any significant bug/issue ?

Updating ose-openshift-apiserver-container image to be consistent with ART for 4.19, we fixed it in main branch(4.20), so need to backport to 4.19, detail see PR #486 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants