-
Notifications
You must be signed in to change notification settings - Fork 98
OCPBUGS-56736: Revert "OCPBUGS-38120: project: run validation function when deleting an object" #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bertinatto: This pull request references Jira Issue OCPBUGS-38120, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload-aggregate periodic-ci-openshift-release-master-nightly-4.20-e2e-vsphere-ovn-serial 10 |
@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/01aef2f0-3b3a-11f0-8b6e-48e5a5038044-0 |
@bertinatto: This pull request references Jira Issue OCPBUGS-56736, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bertinatto: This PR was included in a payload test run from openshift/kubernetes#2148
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c10efc30-3bcb-11f0-985d-535ec0476928-0 |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bertinatto, sosiouxme The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label approved |
/hold cancel We've had 20 runs with this revert and none of them flaked the etcd test. Also, the flake started with the payload that introduced the reverted PR. We agreed on Slack to give this a try. |
/jira refresh |
@bertinatto: This pull request references Jira Issue OCPBUGS-56736, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
bah. it's a revert, we can forgo waiting on a flaky job. |
@sosiouxme: Overrode contexts on behalf of sosiouxme: ci/prow/e2e-aws-ovn-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bertinatto: Jira Issue OCPBUGS-56736: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-56736 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bertinatto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-openshift-apiserver |
Reverts #508
I suspect this caused https://issues.redhat.com/browse/OCPBUGS-56736.
/hold