No-JIRA: Fix conditional labels when in different folder structure than expected

[dfajmon]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix conditional labels when in a different folder structure than expected.

I have my Kubernetes repo in the path openshift/kubernetes. When using openshift-hack/update-test-annotations.sh this would regenerate all of the test labels without the [Suite:k8s.io]. This is because the code expects it to be on the path k8s.io/kubernetes but because it is not, it thinks there are no kubernetes suite tests. We have only kubernetes tests here. I believe we can just omit the part where we add the label on condition. If this proves to be a problem, we should think of a different solution than expecting an absolute path that is not the repository name.

This was half day work trying to figure out why it worked in a container and not on the host (because I chose the registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.23-openshift-4.19 it was indistinguishable). But this will be a problem for all other environments and containers.

Heads up to @jsafrane for helping me with this.

cc @bertinatto
Might know more where else this is used? And if it breaks anything else.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[openshift-ci-robot]

@dfajmon: This pull request explicitly references no jira issue.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix conditional labels when in a different folder structure than expected.

I have my Kubernetes repo in the path openshift/kubernetes. When using openshift-hack/update-test-annotations.sh this would regenerate all of the test labels without the [Suite:k8s.io]. This is because the code expects it on the path k8s.io/kubernetes but because it is not, it thinks there are no kubernetes suites. We have only kubernetes tests here I believe we can just omit the part where we add the label on condition. If this proves to be a problem we should think of different solution than expecting absolute path that is not the repository name.

This was half day work trying to figure out why it worked in container and not on host (because I chose the registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.23-openshift-4.19 it was indistinguishable). This will be a problem for all other environments and containers.

Heads up to @jsafrane for helping me with this.

cc @bertinatto
Might know more where else this is used?

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dfajmon: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 942bfae|fix conditional labels when in different folder structure than expected: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dfajmon
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dfajmon: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• ae8804f|UPSTREAM: : fix conditional labels when in different folder structure than expected: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci-robot]

@dfajmon: This pull request explicitly references no jira issue.

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix conditional labels when in a different folder structure than expected.

I have my Kubernetes repo in the path openshift/kubernetes. When using openshift-hack/update-test-annotations.sh this would regenerate all of the test labels without the [Suite:k8s.io]. This is because the code expects it to be on the path k8s.io/kubernetes but because it is not, it thinks there are no kubernetes suite tests. We have only kubernetes tests here. I believe we can just omit the part where we add the label on condition. If this proves to be a problem, we should think of a different solution than expecting an absolute path that is not the repository name.

This was half day work trying to figure out why it worked in a container and not on the host (because I chose the registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.23-openshift-4.19 it was indistinguishable). But this will be a problem for all other environments and containers.

Heads up to @jsafrane for helping me with this.

cc @bertinatto
Might know more where else this is used? And if it breaks anything other.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dfajmon]

/Retest

[dfajmon]

/retest

[openshift-ci]

@dfajmon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-serial	ae8804f	link	true	/test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-cgroupsv2	ae8804f	link	true	/test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-agnostic-ovn-cmd	ae8804f	link	false	/test e2e-agnostic-ovn-cmd
ci/prow/okd-scos-e2e-aws-ovn	ae8804f	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.