Skip to content

OCPNODE-2929: proposal of OCI image volume #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

OCPNODE-2929: proposal of OCI image volume #1792

merged 3 commits into from
Jul 9, 2025

Conversation

bitoku
Copy link
Contributor

@bitoku bitoku commented May 7, 2025

/assign haircommander
/assign saschagrunert

This is a proposal for how to integrate OCI image volume into OpenShift.

@openshift-ci openshift-ci bot requested review from coverprice and jaypoulz May 7, 2025 18:23
@bitoku bitoku force-pushed the oci-image-volume branch from 4c88477 to 346b211 Compare May 7, 2025 18:31
@bitoku
Copy link
Contributor Author

bitoku commented May 7, 2025

/cc mrunalp

@openshift-ci openshift-ci bot requested a review from mrunalp May 7, 2025 18:56
haircommander
haircommander reviewed May 7, 2025
View reviewed changes
saschagrunert
saschagrunert reviewed May 8, 2025
View reviewed changes
@bitoku bitoku force-pushed the oci-image-volume branch from 346b211 to ec6b9a3 Compare May 8, 2025 10:52
saschagrunert
saschagrunert reviewed May 8, 2025
View reviewed changes
saschagrunert
saschagrunert approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2025
@bitoku
Copy link
Contributor Author

bitoku commented May 12, 2025

@mrunalp @haircommander PTAL for approval.

@bitoku bitoku changed the title Add initial proposal of OCI image volume OCPNODE-2929: proposal of OCI image volume May 13, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025 •
edited by openshift-ci bot
Loading

@bitoku: This pull request references OCPNODE-2929 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.20.0" version, but no target version was set.

In response to this:

/assign haircommander
/assign saschagrunert

This is a proposal for how to integrate OCI image volume into OpenShift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander
Copy link
Member

/lgtm

kannon92
kannon92 reviewed May 19, 2025
View reviewed changes
kannon92
kannon92 reviewed May 19, 2025
View reviewed changes
kannon92
kannon92 reviewed May 19, 2025
View reviewed changes
kannon92
kannon92 reviewed May 19, 2025
View reviewed changes
@bitoku bitoku force-pushed the oci-image-volume branch from ec6b9a3 to 6430707 Compare May 19, 2025 15:23
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@bitoku
Copy link
Contributor Author

bitoku commented May 19, 2025

@kannon92 @haircommander I updated the doc. PTAL

haircommander
haircommander reviewed May 21, 2025
View reviewed changes
kannon92
kannon92 reviewed May 21, 2025
View reviewed changes
kannon92
kannon92 reviewed May 21, 2025
View reviewed changes
@bitoku bitoku force-pushed the oci-image-volume branch 2 times, most recently from 89b662a to 1a7f82b Compare May 22, 2025 16:58
haircommander
haircommander reviewed May 27, 2025
View reviewed changes
@bitoku bitoku force-pushed the oci-image-volume branch from 5d245a4 to 62511be Compare May 27, 2025 15:10
@bitoku bitoku force-pushed the oci-image-volume branch from 62511be to 65ceeb5 Compare May 27, 2025 15:15
@bitoku
Copy link
Contributor Author

bitoku commented May 27, 2025

@haircommander PTAL

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
mrunalp
mrunalp reviewed Jun 11, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2025
@bitoku bitoku force-pushed the oci-image-volume branch from d380aae to 98c252b Compare June 18, 2025 06:41
@bitoku bitoku force-pushed the oci-image-volume branch from 98c252b to f759296 Compare June 18, 2025 06:47
@bitoku
Copy link
Contributor Author

bitoku commented Jun 18, 2025

hmm I ran make lint but nothing changed...

/retest

@haircommander
Copy link
Member

does specifically ./hack/install-markdownlint.sh work? it could also be a problem with the builder image we're using in ci

@bitoku
Copy link
Contributor Author

bitoku commented Jun 19, 2025

@haircommander From my ubuntu machine, I can't run it.

./hack/install-markdownlint.sh: line 14: dnf: command not found

@bitoku
Copy link
Contributor Author

bitoku commented Jun 19, 2025

/retest

haircommander
haircommander reviewed Jun 24, 2025
View reviewed changes
enhancements/kubelet/oci-image-volume.md
- Filename resolution follows this priority order:
1. `org.opencontainers.image.title` annotation
2. `org.cnai.model.filepath` annotation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any relevant notes on decompression?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added decompression and signatures description

@bitoku
Copy link
Contributor Author

bitoku commented Jun 27, 2025

@haircommander @mrunalp Can you PTAL again?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2025
@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@bitoku: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 271c7ed into openshift:master Jul 9, 2025
2 checks passed
@bitoku bitoku mentioned this pull request Jul 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@coverprice coverprice Awaiting requested review from coverprice

@jaypoulz jaypoulz Awaiting requested review from jaypoulz

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

@haircommander haircommander Awaiting requested review from haircommander

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bitoku @openshift-ci-robot @haircommander @mrunalp @saschagrunert @kannon92