Skip to content

STOR-2538: Migrate aws sdk to v2 #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

STOR-2538: Migrate aws sdk to v2 #442

wants to merge 11 commits into from

Conversation

@rhrmo
Copy link
Contributor

@rhrmo rhrmo commented Oct 7, 2025 •
edited
Loading

aws sdk ends support of v1, we need to upgrade to v2

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2025
@openshift-ci openshift-ci bot requested review from gnufied and stephenfin October 7, 2025 13:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhrmo
Once this PR has been reviewed and has the lgtm label, please assign mandre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the request for review from stephenfin November 3, 2025 14:06
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 4, 2025

/retest

@rhrmo rhrmo changed the title [WIP] Migrate aws sdk to v2 Migrate aws sdk to v2 Nov 5, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2025
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 5, 2025

/retest

jsafrane
jsafrane reviewed Nov 6, 2025
View reviewed changes
pkg/driver/aws-efs/aws_efs_tags_controller.go Outdated

// Create or update the tags
_, err := efsClient.TagResource(&efs.TagResourceInput{
_, err := efsClient.TagResource(context.TODO(), &efs.TagResourceInput{
Copy link
Contributor

@jsafrane jsafrane Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ctx from the function arguments

@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 10, 2025

wait for https://github.com/openshift/openshift-tests-private/pull/28085 to merge before retesting

@jsafrane
Copy link
Contributor

jsafrane commented Nov 11, 2025

/retest
https://github.com/openshift/openshift-tests-private/pull/28085 merged 12 hours ago

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@rhrmo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jsafrane
jsafrane reviewed Nov 12, 2025
View reviewed changes
pkg/driver/aws-ebs/aws_ebs_tags_controller.go
var resourceIDs []string
for _, volume := range volumes {
resourceIDs = append(resourceIDs, aws.String(volume.Spec.CSI.VolumeHandle))
resourceIDs = append(resourceIDs, *aws.String(volume.Spec.CSI.VolumeHandle))
Copy link
Contributor

@jsafrane jsafrane Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original code needed array of pointers, so it needed to create the pointers. Now it just needs strings, so just collect them...

Suggested change
resourceIDs = append(resourceIDs, *aws.String(volume.Spec.CSI.VolumeHandle))
resourceIDs = append(resourceIDs, volume.Spec.CSI.VolumeHandle)

@Phaow
Copy link
Contributor

Phaow commented Nov 16, 2025 •
edited by openshift-ci bot
Loading

/retitle STOR-2538: Migrate aws sdk to v2

@openshift-ci openshift-ci bot changed the title Migrate aws sdk to v2 STOR-2538: Migrate aws sdk to v2 Nov 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 16, 2025 •
edited by openshift-ci bot
Loading

@rhrmo: This pull request references STOR-2538 which is a valid jira issue.

In response to this:

aws sdk ends support of v1, we need to upgrade to v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 16, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2025
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 16, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane jsafrane left review comments

@gnufied gnufied Awaiting requested review from gnufied

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhrmo @jsafrane @Phaow @openshift-ci-robot @openshift-merge-robot