OCPBUGS-22456: resourceapply/rbac: fix resource diff logs

[petr-muller]

Previously the logs were wrong and misleading because they were created by diffing a resource after modification which means the actual change is never shown in the diff. These diffs should be created by comparing the resource before and after it is modified.

Partially related to OCPBUGS-36246 but is just a prep for an eventual fix, so marking as NO-JIRA.

Actually fixes part of OCPBUGS-22456

[openshift-ci-robot]

@petr-muller: This pull request explicitly references no jira issue.

In response to this:

Previously the logs were wrong and misleading because they were created by diffing a resource after modification which means the actual change is never shown in the diff. These diffs should be created by comparing the resource before and after it is modified.

Partially related to OCPBUGS-36246 but is just a prep for an eventual fix, so marking as NO-JIRA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-22456, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously the logs were wrong and misleading because they were created by diffing a resource after modification which means the actual change is never shown in the diff. These diffs should be created by comparing the resource before and after it is modified.

Partially related to OCPBUGS-36246 but is just a prep for an eventual fix, so marking as NO-JIRA.

Actually fixes part of OCPBUGS-22456

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	78ce949	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-agnostic-operator-devpreview	78ce949	link	false	/test e2e-agnostic-operator-devpreview
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change	78ce949	link	true	/test e2e-agnostic-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[petr-muller]

/hold

Need to fix some copy-pasta bugs