Skip to content

EXAMPLE: Motivating example for OTA-1531 #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petr-muller
Copy link
Member

Illustrates the caveat of the current approach to determining which gates are enabled and disabled in the cluster. The current approach performs this initialization late in the execution (once the initial payyload is fully loaded) so there is an awkward period on CVO startup where enabled gates cannot be checked and the programmer cannot gate behavior.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
Copy link
Contributor

openshift-ci bot commented May 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@petr-muller
Copy link
Member Author

/test e2e-agnostic-operator e2e-agnostic-ovn-upgrade-into-change unit lint

Illustrates the caveat of the current approach to determining which gates are enabled and disabled in the cluster. The current approach performs this initialization late in the execution (once the initial payyload is fully loaded) so there is an awkward period on CVO startup where enabled gates cannot be checked and the programmer cannot gate behavior.
@petr-muller petr-muller force-pushed the ota-1531-motivating-example branch from de16486 to ba7568b Compare May 6, 2025 16:40
@petr-muller
Copy link
Member Author

/test e2e-agnostic-operator e2e-agnostic-ovn-upgrade-into-change unit lint images

Copy link
Contributor

openshift-ci bot commented May 6, 2025

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-upgrade-into-change ba7568b link true /test e2e-agnostic-ovn-upgrade-into-change
ci/prow/e2e-agnostic-operator ba7568b link true /test e2e-agnostic-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member Author

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1186/pull-ci-openshift-cluster-version-operator-main-e2e-agnostic-ovn-upgrade-into-change/1919795510286225408

There you go:

: [sig-architecture] platform pods in ns/openshift-cluster-version should not exit an excessive amount of times
{  1 containers with multiple restarts

namespace/openshift-cluster-version node/ci-op-9sxh8i8f-c736d-6jxdj-master-0 pod/cluster-version-operator-86654d7c4c-lcsn6 uid/fb7cf998-2a31-4f9e-9f3c-7c7a7b060701 container/cluster-version-operator restarted 24 times at:
non-zero exit at 2025-05-06 18:06:57.252676209 +0000 UTC m=+332.601532538: cause/Error code/2 reason/ContainerExit penshift.io/feature-set=TechPreviewNoUpgrade
...
panic: CVO feature flags were used before they were initialized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant