Skip to content

OCPBUGS-60161: Add mcd_local_unsupported_packages metric from MCO to telemetry #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

OCPBUGS-60161: Add mcd_local_unsupported_packages metric from MCO to telemetry #2638

merged 2 commits into from
Sep 16, 2025

Conversation

dkhater-redhat
Copy link
Contributor

Recently we added mcd_local_unsupported_packages metric in MCO openshift/machine-config-operator#4614 which we would like to get added to telemetry as well.

@dkhater-redhat dkhater-redhat changed the title add mcd_local_unsupported_packages metric from MCO to telemetry OCPBUGS-60161: Add mcd_local_unsupported_packages metric from MCO to telemetry Aug 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 5, 2025
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-60161, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Recently we added mcd_local_unsupported_packages metric in MCO openshift/machine-config-operator#4614 which we would like to get added to telemetry as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier
Copy link
Contributor

We recommend creating a recording rule in MCO to filter away unneeded labels:
https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#configure-recording-rules

We also ask for a formal Jira ticket to get approval from our side. Can you create one as described in https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#request-approval?

@dkhater-redhat
Copy link
Contributor Author

yes wil do. thank you!

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2025
@dkhater-redhat
Copy link
Contributor Author

openshift/machine-config-operator#5242

@dkhater-redhat
Copy link
Contributor Author

updated the metric name to reflect the recording rule change

@dkhater-redhat dkhater-redhat force-pushed the add-mco-telemetry branch 4 times, most recently from 119c86e to 82f8193 Compare August 12, 2025 14:58
@dkhater-redhat
Copy link
Contributor Author

/test e2e-aws-ovn

simonpasquier
simonpasquier reviewed Aug 14, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
we need formal agreement on https://issues.redhat.com/browse/MON-4316

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2025
@dkhater-redhat dkhater-redhat force-pushed the add-mco-telemetry branch 2 times, most recently from 7f76936 to 409b6ef Compare August 18, 2025 15:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2025
@simonpasquier
Copy link
Contributor

@dkhater-redhat you'd need to rebase your PR (there are conflicts).

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2025
@simonpasquier
Copy link
Contributor

/approve
/lgtm
/verified by existing tests

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 16, 2025
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This PR has been marked as verified by existing tests.

In response to this:

/approve
/lgtm
/verified by existing tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2025
@simonpasquier
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2025
@simonpasquier
Copy link
Contributor

/hold cancel

waiting for openshift/machine-config-operator#5242 to merge

@simonpasquier
Copy link
Contributor

/retest-required

@simonpasquier
Copy link
Contributor

/hold

waiting for openshift/machine-config-operator#5242 to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2025
@dkhater-redhat dkhater-redhat mentioned this pull request Sep 16, 2025
Merged
@dkhater-redhat
Copy link
Contributor Author

/unhold

openshift/machine-config-operator#5242 has merged

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 54a344d and 2 for PR HEAD cc63391 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 54a344d and 2 for PR HEAD cc63391 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

@dkhater-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 02d7ad0 into openshift:main Sep 16, 2025
22 checks passed
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: Jira Issue Verification Checks: Jira Issue OCPBUGS-60161
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-60161 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

Recently we added mcd_local_unsupported_packages metric in MCO openshift/machine-config-operator#4614 which we would like to get added to telemetry as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@danielmellado danielmellado Awaiting requested review from danielmellado

@machine424 machine424 Awaiting requested review from machine424

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkhater-redhat @openshift-ci-robot @simonpasquier @openshift-merge-robot