LOG-7009: remove parse and merge data from message to the log event #3033
Conversation
Signed-off-by: Vitalii Parfonov <[email protected]>
|
@vparfonov: This pull request references LOG-7009 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vparfonov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -131,30 +131,6 @@ var _ = Describe("[Functional][Outputs][Syslog] Functional tests", func() { | |||
| Expect(getProcID(fields)).To(Equal("myproc")) | |||
| Expect(getMsgID(fields)).To(Equal("mymsg")) | |||
| }) | |||
| It("should take values of appname, procid, messageid from record", func() { | |||
There was a problem hiding this comment.
Let's try to enable these tests by introducing the JSON parse filter to demonstrate how this functionality should be work
There was a problem hiding this comment.
5.9 don't have JSON parse filter, i will do it in 6.x
| @@ -55,37 +55,9 @@ var _ = Describe("[Functional][Outputs][Syslog] RFC3164 tests", func() { | |||
| Expect(outputlogs[0]).To(MatchRegexp(expMatch), "Exp to find tag in received message") | |||
| Expect(outputlogs[0]).To(MatchRegexp(`{"index":.*1,.*"timestamp":.*1,.*"tag_key":.*"rec_tag"}`), "Exp to find the original message in received message") | |||
| }, | |||
|
|
|||
| Entry("should use the value from the record and include the message", "$.message.tag_key", "rec_tag", false), | |||
There was a problem hiding this comment.
Same comment here. Also, let's add a test which demonstrates the bug no longer exists and proves we fixed it
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vparfonov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Description
This PR addresses several issues caused by problematic behavior introduced during the migration from
FluentdtoVector. These issues are related to parsing and merging data from the message into the log event, which can result in system information being overwritten, data being duplicated, or log events becoming corrupted. This fix also helps align the Syslog output with other output types because it was introduced only for Syslog output./cc @Clee2691 @cahartma
/assign @jcantrill
Links