[release-5.9]LOG-6963:Map cluster-wide proxy env variable for compatibility with Vector expectations

[vparfonov]

Description

Adding cluster-wide proxy automatically inject the environment variable, to support Fluentd collector they was lowercased to http_proxy, https_proxy and no_proxy. In the same time, the Vector expects the variable to be named HTTP_PROXY, HTTPS_PROXY and NO_PROXY (in uppercase) [1]. This mismatch causes the Vector not picked up proxy settings.

This PR adds a mechanism to support both collectors in the Vector value will be remapped according to current collector expectations.

[1] https://github.com/vectordotdev/vector/blob/f5b9265335c9df7bcbd4a57046738fb5e87a67c1/lib/vector-core/src/config/proxy.rs#L121

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

• Depending on PR(s): [release-5.9]LOG-6963: url-encoded for proxy authorization settings ViaQ/vector#207
• GitHub issue:
• JIRA: https://issues.redhat.com/browse/LOG-6963
• Enhancement proposal:

[cahartma]

This should most likely be fixed in 6.2 (and master), rather than 5.9. Also, I'm not seeing how this is related to fixing the '@' issue in: https://issues.redhat.com/browse/LOG-6963

[cahartma]

Shouldn't we be merging this fix into master and release-6.2 first. Is there a way we can resolve this in v6, then tell them to upgrade if they complain about not fixing in v5?

[vparfonov]

This should most likely be fixed in 6.2 (and master), rather than 5.9. Also, I'm not seeing how this is related to fixing the '@' issue in: issues.redhat.com/browse/LOG-6963

Vector just don't picked up env value in lowercase, not related directly to the @

Something similar was here: https://issues.redhat.com/browse/LOG-4900

[vparfonov]

Shouldn't we be merging this fix into master and release-6.2 first. Is there a way we can resolve this in v6, then tell them to upgrade if they complain about not fixing in v5?

Maybe yes, original issue opened for 5.9 thats why i did it firstly

[jcantrill]

/hold

[vparfonov]

/retest

[openshift-ci-robot]

@vparfonov: This pull request references LOG-6963 which is a valid jira issue.

In response to this:

Description

Adding cluster-wide proxy automatically inject the environment variable http_proxy, https_proxy and no_proxy (in lowercase) but the Vector expects the variable to be named HTTP_PROXY, HTTPS_PROXY and NO_PROXY (in uppercase). This mismatch causes the Vector not picked up proxy settings.

This PR adds a fallback mechanism in the Vector startup script to remap the existed lowercase value to uppercase.
[1] https://github.com/vectordotdev/vector/blob/f5b9265335c9df7bcbd4a57046738fb5e87a67c1/lib/vector-core/src/config/proxy.rs#L121

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

• Depending on PR(s):
• GitHub issue:
• JIRA: https://issues.redhat.com/browse/LOG-6963
• Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vparfonov: This pull request references LOG-6963 which is a valid jira issue.

In response to this:

Description

Adding cluster-wide proxy automatically inject the environment variable, to support Fluentd collector they was lowercased to http_proxy, https_proxy and no_proxy. In the same time, the Vector expects the variable to be named HTTP_PROXY, HTTPS_PROXY and NO_PROXY (in uppercase) [1]. This mismatch causes the Vector not picked up proxy settings.

This PR adds a mechanism to support both collectors in the Vector value will be remapped according to current collector expectations.

[1] https://github.com/vectordotdev/vector/blob/f5b9265335c9df7bcbd4a57046738fb5e87a67c1/lib/vector-core/src/config/proxy.rs#L121

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

• Depending on PR(s):
• GitHub issue:
• JIRA: https://issues.redhat.com/browse/LOG-6963
• Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jcantrill]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[anpingli]

@vparfonov According to my test result(Vector to Splunk). https_proxy/http_proxy and HTTPS_PROXY/HTTP_RPOXY are same. No matter which one is specified, the PROXY will be used.
With HTTPS_RPOXY, the vector still fails to forward logs to splunk when the proxy name incude encoded @.

[vparfonov]

@vparfonov According to my test result(Vector to Splunk). https_proxy/http_proxy and HTTPS_PROXY/HTTP_RPOXY are same. No matter which one is specified, the PROXY will be used. With HTTPS_RPOXY, the vector still fails to forward logs to splunk when the proxy name incude encoded @.

Yes my bad i tested with later version of Vector, going to fix for 5.9

[openshift-ci-robot]

@vparfonov: This pull request references LOG-6963 which is a valid jira issue.

In response to this:

Description

Adding cluster-wide proxy automatically inject the environment variable, to support Fluentd collector they was lowercased to http_proxy, https_proxy and no_proxy. In the same time, the Vector expects the variable to be named HTTP_PROXY, HTTPS_PROXY and NO_PROXY (in uppercase) [1]. This mismatch causes the Vector not picked up proxy settings.

This PR adds a mechanism to support both collectors in the Vector value will be remapped according to current collector expectations.

[1] https://github.com/vectordotdev/vector/blob/f5b9265335c9df7bcbd4a57046738fb5e87a67c1/lib/vector-core/src/config/proxy.rs#L121

/cc @Clee2691 @cahartma
/assign @jcantrill

Links

• Depending on PR(s): [release-5.9]LOG-6963: url-encoded for proxy authorization settings ViaQ/vector#207
• GitHub issue:
• JIRA: https://issues.redhat.com/browse/LOG-6963
• Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.