Skip to content

Conversation

@rpodishe
Copy link
Contributor

@rpodishe rpodishe commented Nov 5, 2025

  • Updated deps as per the release 4.20
  • Validated the functionality
  • Validated the metrics and logs

- Update Go version to 1.24.0
- Update k8s.io/api, apimachinery, client-go to v0.33.2
- Update k8s.io/apiextensions-apiserver to v0.33.2
- Update sigs.k8s.io/controller-runtime to v0.21.0
- Update github.com/openshift/api to release-4.20
@openshift-ci openshift-ci bot requested review from Tafhim and ravitri November 5, 2025 10:37
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.15%. Comparing base (7718f12) to head (f9c6540).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   57.15%   57.15%           
=======================================
  Files          29       29           
  Lines        2138     2138           
=======================================
  Hits         1222     1222           
  Misses        802      802           
  Partials      114      114           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tkong-redhat
Copy link

The changes looks good to me. Just wondering did you use the update script to bump the dependency? Any manual work required?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@rpodishe
Copy link
Contributor Author

rpodishe commented Nov 6, 2025

The changes looks good to me. Just wondering did you use the update script to bump the dependency? Any manual work required?

@tkong-redhat Thanks for the review. The dependency update was done manually—there isn't an automated update script for Go dependencies in this repo.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@rpodishe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@charlesgong
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@rpodishe
Copy link
Contributor Author

@clcollins @dustman9000 @iamkirkbater
Could you please review and approve if no comments?
got lgtm, waiting for approval.

@rpodishe
Copy link
Contributor Author

/retest

@ravitri
Copy link
Member

ravitri commented Nov 11, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charlesgong, ravitri, rpodishe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit aa9e33a into openshift:master Nov 11, 2025
12 checks passed
@rpodishe rpodishe deleted the SREP-2339-update-deps-certman branch November 11, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants