-
Notifications
You must be signed in to change notification settings - Fork 80
SREP-2339 update deps for ocp 4.20 #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SREP-2339 update deps for ocp 4.20 #405
Conversation
rpodishe
commented
Nov 5, 2025
- Updated deps as per the release 4.20
- Validated the functionality
- Validated the metrics and logs
- Update Go version to 1.24.0 - Update k8s.io/api, apimachinery, client-go to v0.33.2 - Update k8s.io/apiextensions-apiserver to v0.33.2 - Update sigs.k8s.io/controller-runtime to v0.21.0 - Update github.com/openshift/api to release-4.20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 57.15% 57.15%
=======================================
Files 29 29
Lines 2138 2138
=======================================
Hits 1222 1222
Misses 802 802
Partials 114 114 🚀 New features to boost your workflow:
|
|
The changes looks good to me. Just wondering did you use the update script to bump the dependency? Any manual work required? |
@tkong-redhat Thanks for the review. The dependency update was done manually—there isn't an automated update script for Go dependencies in this repo. |
|
@rpodishe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@clcollins @dustman9000 @iamkirkbater |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charlesgong, ravitri, rpodishe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |