Fix useRoleBindings to properly use Role instead of ClusterRole #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1130 When useRoleBindings is set to true, the operator should create Role and RoleBinding resources instead of ClusterRole and ClusterRoleBinding to allow installation with namespace-level privileges. This fix updates the following templates to conditionally use Role when useRoleBindings is true: - opensearch-operator-manager-role-cr.yaml: Now creates Role when useRoleBindings is true, otherwise creates ClusterRole - opensearch-operator-manager-rolebinding.yaml: Now references Role when useRoleBindings is true - opensearch-operator-metrics-reader-cr.yaml: Now creates Role when useRoleBindings is true, otherwise creates ClusterRole - opensearch-operator-proxy-role-cr.yaml: Now creates Role when useRoleBindings is true, otherwise creates ClusterRole - opensearch-operator-proxy-rolebinding.yaml: Now references Role when useRoleBindings is true This enables users with only namespace admin privileges to install the operator successfully.
This was referenced Oct 16, 2025
Comment on lines
+7
to
+10
| - nonResourceURLs: | ||
| - /metrics | ||
| verbs: | ||
| - get |
There was a problem hiding this comment.
Namespaced rules cannot apply to non-resource URLs.
|
I'd close this PR because Namespaced rules cannot apply to non-resource URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1130
When useRoleBindings is set to true, the operator should create Role and RoleBinding resources instead of ClusterRole and ClusterRoleBinding to allow installation with namespace-level privileges.
This fix updates the following templates to conditionally use Role when useRoleBindings is true:
This enables users with only namespace admin privileges to install the operator successfully.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.