feat(pvc): Allow custom labels and annotations on PVCs #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannonski
requested review from
idanl21,
jochenkressin,
pchmielnik,
prudhvigodithi,
salyh and
swoehrl-mw
as code owners
|
@kannonski we can merge once DCO check is fixed (you can squash, sign off and force push) |
synhershko
approved these changes
Oct 17, 2025
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
kannonski
force-pushed
the
unblu/feature/pvc-annotation
branch
from
bf2f104 to
40e9d4b
Compare
|
@synhershko can you do a last review, before squash and merge |
|
@kannonski @josedev-union CI seems to be stuck, possibly because of the change? |
kannonski
force-pushed
the
unblu/feature/pvc-annotation
branch
2 times, most recently
from
b7a6a47 to
905c60e
Compare
This commit introduces two new fields, `labels` and `annotations`, to the persistence configuration for PVCs.
This allows users to specify their own metadata on the PersistentVolumeClaims created by the operator. This is necessary for integrations with other tools, such as storage encryption systems or cost-monitoring platforms that rely on specific annotations or labels.
Example usage:
```yaml
spec:
nodePools:
- component: data
persistence:
pvc:
labels:
team: "backend-data"
annotations:
test.io/crypt-key-id: "your-kms-key-id"
```
Signed-off-by: Okkan SERIN <[email protected]>
adding test units
Signed-off-by: Okkan SERIN <[email protected]>
updating helm charts crd
Signed-off-by: Okkan SERIN <[email protected]>
updating user guide
Signed-off-by: Okkan SERIN <[email protected]>
adding missing generated code
Signed-off-by: Okkan SERIN <[email protected]>
fix node.Persistence == nil
Signed-off-by: Okkan SERIN <[email protected]>
kannonski
force-pushed
the
unblu/feature/pvc-annotation
branch
from
5fe322c to
dd681cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces two new fields,
labelsandannotations, to the persistence configuration for PVCs.This allows users to specify their own metadata on the PersistentVolumeClaims created by the operator. This is necessary for integrations with other tools, such as storage encryption systems or cost-monitoring platforms that rely on specific annotations or labels.
Example usage:
Signed-off-by: Okkan SERIN <[email protected]>
Issues Resolved
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.